Improved Avro error reporting related to schemas #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlvenable
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed and
oeyh
as code owners
cmanning09
previously approved these changes
Aug 8, 2023
| @@ -179,6 +176,9 @@ private GenericRecord buildAvroRecord(final Schema schema, final Map<String, Obj | |||
| continue; | |||
| } | |||
| final Schema.Field field = schema.getField(key); | |||
| if(field == null) { | |||
There was a problem hiding this comment.
(Only because you fixed other spacing issues in this PR)
You are missing a space after the if
if (field == null) {
Comment on lines
+47
to
+48
| final Map<String, Object> stringObjectMap = objectMapper.readValue(s3Object, new TypeReference<>() { | ||
| }); |
There was a problem hiding this comment.
Was this change intentional to split into two lines?
There was a problem hiding this comment.
This is what my IntelliJ formatter produced.
chenqi0805
reviewed
Aug 8, 2023
...avro-codecs/src/main/java/org/opensearch/dataprepper/plugins/codec/avro/AvroOutputCodec.java
Outdated
Show resolved
Hide resolved
…exception when an Avro field is missing from the schema. Signed-off-by: David Venable <dlv@amazon.com>
dlvenable
force-pushed
the
avro-schema-startup
branch
from
f386b42
to
1eb7926
Compare
Signed-off-by: David Venable <dlv@amazon.com>
|
I had to rebase and force push due to changes from #3122. Please take another look. Thanks! |
chenqi0805
approved these changes
Aug 9, 2023
cmanning09
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has two major updates:
Additionally, this PR includes some code clean-up.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.