-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry s3 reads on socket exceptions. #2992
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
I think we also need to bubble up any fatal exceptions from this class here to prevent deleting the SQS message on read failure
Good call. I've added a commit to bubble up that exception. |
S3 will reset the conenction on their end frequently. To not lose data, data prepper should retry all socket exceptions by attempting to re-open the stream. Signed-off-by: Adi Suresh <adsuresh@amazon.com>
Signed-off-by: Adi Suresh <adsuresh@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.3 2.3
# Navigate to the new working tree
cd .worktrees/backport-2.3
# Create a new branch
git switch --create backport/backport-2992-to-2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9f78542533dd24ed21e29a12950938c0c4b23636
# Push it to GitHub
git push --set-upstream origin backport/backport-2992-to-2.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.3 Then, create a pull request where the |
* Retry s3 reads on socket exceptions. S3 will reset the conenction on their end frequently. To not lose data, data prepper should retry all socket exceptions by attempting to re-open the stream. Signed-off-by: Adi Suresh <adsuresh@amazon.com> * Bubble up parquet exceptions. Signed-off-by: Adi Suresh <adsuresh@amazon.com> --------- Signed-off-by: Adi Suresh <adsuresh@amazon.com> (cherry picked from commit 9f78542)
* Retry s3 reads on socket exceptions. S3 will reset the conenction on their end frequently. To not lose data, data prepper should retry all socket exceptions by attempting to re-open the stream. Signed-off-by: Adi Suresh <adsuresh@amazon.com> * Bubble up parquet exceptions. Signed-off-by: Adi Suresh <adsuresh@amazon.com> --------- Signed-off-by: Adi Suresh <adsuresh@amazon.com> (cherry picked from commit 9f78542) Co-authored-by: Adi Suresh <adsuresh@amazon.com>
* Retry s3 reads on socket exceptions. S3 will reset the conenction on their end frequently. To not lose data, data prepper should retry all socket exceptions by attempting to re-open the stream. Signed-off-by: Adi Suresh <adsuresh@amazon.com> * Bubble up parquet exceptions. Signed-off-by: Adi Suresh <adsuresh@amazon.com> --------- Signed-off-by: Adi Suresh <adsuresh@amazon.com> Signed-off-by: George Chen <qchea@amazon.com>
* Retry s3 reads on socket exceptions. S3 will reset the conenction on their end frequently. To not lose data, data prepper should retry all socket exceptions by attempting to re-open the stream. Signed-off-by: Adi Suresh <adsuresh@amazon.com> * Bubble up parquet exceptions. Signed-off-by: Adi Suresh <adsuresh@amazon.com> --------- Signed-off-by: Adi Suresh <adsuresh@amazon.com> Signed-off-by: Marcos Gonzalez Mayedo <alemayed@amazon.com>
S3 will reset the conenction on their end frequently. To not lose data, data prepper should retry all socket exceptions by attempting to re-open the stream.
Description
Retries all socket exceptions
Issues Resolved
S3 socket exceptions causing records to get dropped
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.