Connection code of HttpSink Plugin for #874. #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mallikagogoi7 <mallikagogoi7@gmail.com>
mallikagogoi7
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
oeyh
reviewed
Jul 12, 2023
Comment on lines
+14
to
+16
| HTTP_BASIC("http_basic"), | ||
| BEARER_TOKEN("bearer_token"), | ||
| UNAUTHENTICATED("unauthenticated"); |
There was a problem hiding this comment.
Requirements say mTLS as well. Is it going to be supported here?
There was a problem hiding this comment.
Thanks for the review @oeyh Yes, mTLS is also supported.
Comment on lines
108
to
131
| if (currentBuffer == null) { | ||
| this.currentBuffer = bufferFactory.getBuffer(); | ||
| } | ||
| records.forEach(record -> { | ||
| try{ | ||
| // logic to fetch the records in batch as per threshold limit - checkThresholdExceed(); | ||
| // apply the codec | ||
| // push to http end point | ||
| }catch(Exception e){ | ||
| // In case of any exception, need to write the exception in dlq - logFailureForDlqObjects(); | ||
| // In case of any exception, need to push the web hook url- logFailureForWebHook(); | ||
| final Event event = record.getData(); | ||
| try { | ||
| currentBuffer.writeEvent(event.toJsonString().getBytes()); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| if(event.getEventHandle() != null) { | ||
| this.bufferedEventHandles.add(event.getEventHandle()); | ||
| } | ||
| //TODO: implement end to end acknowledgement | ||
| final List<HttpEndPointResponse> failedHttpEndPointResponses = pushToEndPoint(getCurrentBufferData(currentBuffer)); | ||
| if(!failedHttpEndPointResponses.isEmpty()) { | ||
| //TODO send to DLQ and webhook | ||
| } else { | ||
| LOG.info("data pushed to all the end points successfully"); | ||
| } | ||
| currentBuffer = bufferFactory.getBuffer(); | ||
| releaseEventHandles(Boolean.TRUE); | ||
|
|
||
| }); | ||
| reentrantLock.unlock(); |
There was a problem hiding this comment.
It's probably better to put those in a try-finally block to make sure the lock will be released.
There was a problem hiding this comment.
This function is yet to be completed, right? Threshold options haven't been incorporated here. We also may not want to throw an exception in the middle of the loop to interrupt the output.
There was a problem hiding this comment.
Thanks for the review @oeyh , PR is updated with try-finally block and Threshold implementation shall be in the next PR.
Signed-off-by: mallikagogoi7 <mallikagogoi7@gmail.com>
oeyh
approved these changes
Jul 14, 2023
graytaylor0
approved these changes
Jul 14, 2023
chenqi0805
pushed a commit
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Connection code of HttpSink Plugin for #874.
Issues Resolved
Resolves #874
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.