GitHub-issue#2822: Define null characters in convert processor #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saydar31
requested review from
chenqi0805,
engechas,
graytaylor0,
dinujoh,
kkondaka,
cmanning09,
asifsmohammed,
dlvenable and
oeyh
as code owners
Signed-off-by: Aidar Shaidullin <ajdarshaydullin@gmail.com> Signed-off-by: saydar31 <ajdarshaydullin@gmail.com>
Signed-off-by: saydar31 <ajdarshaydullin@gmail.com>
dlvenable
requested changes
Jun 7, 2023
| import static org.mockito.Mockito.when; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| public class NullValuesTests { |
There was a problem hiding this comment.
Please rename this to ConvertEntryTypeProcessor_NullValueTests so that it is a bit more connected with the processor.
Signed-off-by: saydar31 <ajdarshaydullin@gmail.com>
dlvenable
approved these changes
Jun 8, 2023
MaGonzalMayedo
pushed a commit
to MaGonzalMayedo/data-prepper
that referenced
this pull request
Jun 21, 2023
…earch-project#2844) GitHub-issue#2822: Define null characters in convert processor Signed-off-by: Aidar Shaidullin <ajdarshaydullin@gmail.com> Signed-off-by: saydar31 <ajdarshaydullin@gmail.com> --------- Signed-off-by: saydar31 <ajdarshaydullin@gmail.com> Co-authored-by: saydar31 <ajdarshaydullin@gmail.com> Signed-off-by: Marcos_Gonzalez_Mayedo <alemayed@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
GitHub-issue#2822: Define null characters in convert processor Signed-off-by: Aidar Shaidullin <ajdarshaydullin@gmail.com> Signed-off-by: saydar31 <ajdarshaydullin@gmail.com> --------- Signed-off-by: saydar31 <ajdarshaydullin@gmail.com> Co-authored-by: saydar31 <ajdarshaydullin@gmail.com> (cherry picked from commit 8e1568d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add null_values feature
Issues Resolved
Resolve #2822
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.