Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null support to DataPrepperExpressions #1136

Closed
sbayer55 opened this issue Mar 2, 2022 · 2 comments
Closed

Add null support to DataPrepperExpressions #1136

sbayer55 opened this issue Mar 2, 2022 · 2 comments
Assignees
Labels
backlog enhancement New feature or request
Milestone

Comments

@sbayer55
Copy link
Member

sbayer55 commented Mar 2, 2022

Is your feature request related to a problem? Please describe.
Today if a JsonPointer results in a null value an exception is thrown. Using Data Prepper Expression Syntax null values cannot be hard coded. As of Data Prepper 1.3.0 all operators are not null safe.

Describe the solution you'd like
Add support for a null keyword.

Example:

/status_code in {null, 400, 404}

Describe alternatives you've considered (Optional)
Handling null values with exceptions.

Additional context
n/a

@dlvenable dlvenable added backlog enhancement New feature or request and removed untriaged labels Apr 19, 2022
kkondaka added a commit to kkondaka/kk-data-prepper-f2 that referenced this issue Oct 19, 2022
@kkondaka
Copy link
Collaborator

We will support equal and not-equal operators with "null" keyword initially. Support for "in" operator may be added later.

kkondaka added a commit to kkondaka/kk-data-prepper-f2 that referenced this issue Oct 19, 2022
kkondaka added a commit to kkondaka/kk-data-prepper-f2 that referenced this issue Oct 19, 2022
@kkondaka kkondaka mentioned this issue Oct 19, 2022
1 task
kkondaka added a commit to kkondaka/kk-data-prepper-f2 that referenced this issue Oct 19, 2022
…Expressions

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
kkondaka added a commit to kkondaka/kk-data-prepper-f2 that referenced this issue Oct 19, 2022
…Expressions - added more tests

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
kkondaka added a commit to kkondaka/kk-data-prepper-f2 that referenced this issue Oct 19, 2022
…Expressions - updated docs

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
kkondaka added a commit to kkondaka/kk-data-prepper-f2 that referenced this issue Oct 20, 2022
…Expressions

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
kkondaka added a commit to kkondaka/kk-data-prepper-f2 that referenced this issue Oct 20, 2022
…Expressions - added more tests

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
kkondaka added a commit to kkondaka/kk-data-prepper-f2 that referenced this issue Oct 20, 2022
…Expressions - updated docs

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
dlvenable pushed a commit that referenced this issue Oct 25, 2022
* fix for issue #1136 Add null support to DataPrepperExpressions

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>

* fix for issue #1136 Add null support to DataPrepperExpressions - added more tests

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>

* fix for issue #1136 Add null support to DataPrepperExpressions - updated docs

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>

* Addressed review comments - added test cases and updated document

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>

Signed-off-by: Krishna Kondaka <krishkdk@amazon.com>
Co-authored-by: Krishna Kondaka <krishkdk@amazon.com>
@dlvenable dlvenable added this to the v2.1 milestone Nov 11, 2022
@dlvenable
Copy link
Member

Closed by #1946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants