[CI/CD] Add single version flag during bootstrap to fix version conflicts #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Liang <jiallian@amazon.com>
RyanL1997
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
RyanL1997
changed the title
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
rupal-bq
approved these changes
Feb 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #341 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 5 5
Lines 152 152
Branches 45 45
=======================================
Hits 144 144
Misses 8 8 ☔ View full report in Codecov by Sentry. |
ps48
approved these changes
Feb 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 19, 2024
…icts (#341) * Add single version flag during bootstrap to fix version conflicts Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add the flag to build workflow too Signed-off-by: Ryan Liang <jiallian@amazon.com> * Add the flag to build workflow too 2 Signed-off-by: Ryan Liang <jiallian@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> (cherry picked from commit 3b4d3a2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Feb 20, 2024
…icts (#341) (#342) * Add single version flag during bootstrap to fix version conflicts * Add the flag to build workflow too * Add the flag to build workflow too 2 --------- (cherry picked from commit 3b4d3a2) Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On behalf of the change in dashboards core: opensearch-project/OpenSearch-Dashboards#5675. We need to add
--single-version=looseflag during the bootstrap step in our CI to manipulate the behavior of single-version validation.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.