-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move gantt-chart out from subdirectory #321
Move gantt-chart out from subdirectory #321
Conversation
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 5 5
Lines 152 152
Branches 45 45
=======================================
Hits 144 144
Misses 8 8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Do you want to backport this for 2.12 release? |
yes but doesn't need to be in 2.12, since it doesn't make a difference for users. i'll try to make it in because the build repo doesn't version the build scripts, it becomes difficult to manage if main and 2.x are using different build script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Looks good. Thanks. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-visualizations/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-visualizations/backport-2.x
# Create a new branch
git switch --create backport/backport-321-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 12ad9b729ad3290c84a7cb5c681aca94f7102efe
# Push it to GitHub
git push --set-upstream origin backport/backport-321-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-visualizations/backport-2.x Then, create a pull request where the |
Signed-off-by: Joshua Li <joshuali925@gmail.com> (cherry picked from commit 12ad9b7)
opensearch-project/dashboards-visualizations#321 moved this plugin from a sub-dir, such that special case for it should not be needed anymore. Signed-off-by: Dimitri John Ledkov <19779+xnox@users.noreply.github.com>
Description
Currently all frontend plugins are under git root except gantt-chart, this PR makes the directory structure more consistent with other plugins.
This PR is a prerequisite for opensearch-project/opensearch-build#4375, which will do the corresponding change in the build repo
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.