Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add Ability to Select a Search Pipeline in Comparison Tool #352

Merged
merged 13 commits into from
Jan 26, 2024
Merged

Feature: Add Ability to Select a Search Pipeline in Comparison Tool #352

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
19f941a
Add search pipeline parameters to index and route files
nung22 Nov 19, 2023
80026e4
Add search pipeline dropdown
nung22 Nov 19, 2023
e116927
Integrate option to select search pipeline
nung22 Nov 21, 2023
ed36912
Update tests and snapshots
nung22 Nov 22, 2023
86b52e6
Update get pipelines endpoint
nung22 Nov 27, 2023
40de9e5
Update .babelrc
nung22 Nov 27, 2023
5e0d22f
Update test snapshots
nung22 Nov 27, 2023
88f1b02
Add id attribute to search bar (#338)
nung22 Nov 29, 2023
141e5c0
Update .babelrc
nung22 Dec 5, 2023
78b9870
Merge remote-tracking branch 'upstream' into feature/issue-260
nung22 Dec 12, 2023
5599b94
Add ability to select _none option
nung22 Dec 13, 2023
a7fba79
Update test coverages
nung22 Dec 19, 2023
765cf71
Update variables in pipeline selection
nung22 Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test coverages 
Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>
  • Loading branch information
@nung22
nung22 committed Dec 19, 2023
commit a7fba795f88bdf5fd49e04fc2903a605e49449f4
5 changes: 5 additions & 0 deletions ...components/query_compare/search_result/search_components/__tests__/search_config.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,14 @@ describe('Flyout component', () => {
wrapper.find('EuiCodeEditor').prop('onChange')?.({ target: { value: '' } });
wrapper.find('EuiSelect').prop('onChange')?.({ target: {} });
wrapper.find('EuiSelect').prop('onBlur')?.({ target: {} });
wrapper.find('EuiComboBox').prop('onChange')?.({ target: { selectedOptions: [] } });
wrapper.find('EuiComboBox').prop('onChange')?.({
target: { selectedOptions: [{ label: '_none' }] },
});
});
expect(setQueryString).toHaveBeenCalledTimes(1);
expect(setSelectedIndex).toHaveBeenCalledTimes(1);
expect(setPipeline).toHaveBeenCalledTimes(2);
expect(setQueryError).toHaveBeenCalledTimes(3);
});
});
33 changes: 15 additions & 18 deletions ...components/query_compare/search_result/search_components/search_configs/search_config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,17 @@ export const SearchConfig: FunctionComponent<SearchConfigProps> = ({
};

// Sort search pipelines based off of each individual pipeline name.
const sortedPipelines = [...Object.keys(pipelines)].sort((a, b) => a.localeCompare(b));
sortedPipelines.push('_none');
const sortedPipelines = [...Object.keys(pipelines)]
.sort((a, b) => a.localeCompare(b))
.map((searchPipeline) => ({
label: searchPipeline,
}));
// Add the '_none' option to the pipeline dropdown (runs the index without a pipeline).
sortedPipelines.push({ label: '_none' });

// On select index for ComboBox
const onChangePipeline = (selectedOptions: string | any[]) => {
if (selectedOptions.length === 0) {
setPipeline('');
} else {
setPipeline(selectedOptions[0].label);
}
setPipeline(selectedOptions[0]?.label || '');
};

// Select index on blur
Expand Down Expand Up @@ -131,17 +132,13 @@ export const SearchConfig: FunctionComponent<SearchConfigProps> = ({
</EuiFlexItem>
<EuiFlexItem>
<EuiFormRow fullWidth label="Pipeline" helpText="Optional">
{
<EuiComboBox
placeholder=""
singleSelection={{ asPlainText: true }}
options={sortedPipelines.map((searchPipeline) => ({
label: searchPipeline,
}))}
selectedOptions={pipeline ? [{ label: pipeline }] : []}
onChange={onChangePipeline}
/>
}
<EuiComboBox
placeholder=""
singleSelection={{ asPlainText: true }}
options={sortedPipelines}
selectedOptions={pipeline ? [{ label: pipeline }] : []}
onChange={onChangePipeline}
/>
</EuiFormRow>
</EuiFlexItem>
</EuiFlexGroup>
Expand Down