Feature: Add Option to Expand Document Source #350

nung22 · 2023-11-06T19:10:30Z

Description

Gives users the ability to expand the row to view the entire document source with OuiPopover. Also refactors the getDlTmpl functional component by using OuiDescriptionList, OuiDescriptionListTitle, and OuiDescriptionListDescription in place of standard HTML tags. Removes the : in the source fields headers and updates their styling as well to make them more distinguishable from their values.

Issues Resolved

Closes #285

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Screenshots

Source details closed

Source details open

In action

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

codecov · 2023-11-06T19:20:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (75f66b9) to head (4e849c5).
Report is 1 commits behind head on main.

❗ Current head 4e849c5 differs from pull request most recent head 7744616. Consider uploading reports for the commit 7744616 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   83.13%   84.74%   +1.61%     
==========================================
  Files          32       32              
  Lines         415      413       -2     
  Branches       81       81              
==========================================
+ Hits          345      350       +5     
+ Misses         49       43       -6     
+ Partials       21       20       -1

Flag	Coverage Δ
dashboards-search-relevance	`84.74% <100.00%> (+1.61%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

kgcreative · 2023-11-21T00:07:22Z

Nice incremental update here

public/components/query_compare/search_result/result_components/result_panel.tsx

public/components/query_compare/search_result/result_components/result_grid.tsx

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

sejli

Great work, I love it! Left one nitpick comment, but may need to change the .babelrc as it's not passing tests still.

public/components/query_compare/search_result/result_components/result_grid.tsx

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

This reverts commit 8ec3868. Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

Update merge changes

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

…rds-search-relevance into feature/issue-285

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

package.json

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

nung22

Thanks for catching that! Just removed it.

package.json

Signed-off-by: Sean Li <lnse@amazon.com>

* Add option to expand document source Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Remove redundant code Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update test coverage Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Remove unused queryerror Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update styling of results Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update dependencies Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Add option to expand document source Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Remove redundant code Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update test coverage Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Remove unused queryerror Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update styling of results Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update dependencies Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Revert "Update dependencies" This reverts commit 8ec3868. Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> Update merge changes * Move styling to scss file Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update snapshots Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Update yarn.lock Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * Remove unnecessary line in package.json Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> * manually updating snapshots for nung22 Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> Signed-off-by: Sean Li <lnse@amazon.com> Co-authored-by: Sean Li <lnse@amazon.com> (cherry picked from commit 4e9feca) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Add option to expand document source * Remove redundant code * Update test coverage * Remove unused queryerror * Update styling of results * Update dependencies * Add option to expand document source * Remove redundant code * Update test coverage * Remove unused queryerror * Update styling of results * Update dependencies * Revert "Update dependencies" This reverts commit 8ec3868. * Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> Update merge changes * Move styling to scss file * Update snapshots * Update yarn.lock * Remove unnecessary line in package.json * manually updating snapshots for nung22 --------- (cherry picked from commit 4e9feca) Signed-off-by: Nicholas Ung <nicholasung22@gmail.com> Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Li <lnse@amazon.com>

Add option to expand document source

c0cb8d3

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

nung22 requested review from macohen, mingshl, msfroh, noCharger and sejli as code owners November 6, 2023 19:10

nung22 changed the title ~~Add option to expand document source~~ Add Option to Expand Document Source Nov 6, 2023

nung22 added 2 commits November 8, 2023 23:56

Remove redundant code

3056a2d

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

Update test coverage

63f8ca1

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

sejli reviewed Nov 21, 2023

View reviewed changes

public/components/query_compare/search_result/result_components/result_panel.tsx Outdated Show resolved Hide resolved

public/components/query_compare/search_result/result_components/result_grid.tsx Outdated Show resolved Hide resolved

nung22 added 2 commits November 27, 2023 14:39

Remove unused queryerror

e8e1a6e

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

Update styling of results

fb8a0b6

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

sejli reviewed Nov 28, 2023

View reviewed changes

public/components/query_compare/search_result/result_components/result_grid.tsx Outdated Show resolved Hide resolved

nung22 added 8 commits November 28, 2023 16:40

Update dependencies

8ec3868

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

Add option to expand document source

878b0d4

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

Remove redundant code

b196f18

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

Update test coverage

31ade86

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

Remove unused queryerror

b331171

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

Update styling of results

3a13910

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

Update dependencies

0c24c35

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

Revert "Update dependencies"

3e8134d

This reverts commit 8ec3868. Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

nung22 force-pushed the feature/issue-285 branch from 6f5cfa8 to 3e8134d Compare November 29, 2023 22:47

nung22 changed the title ~~Add Option to Expand Document Source~~ Feature: Add Option to Expand Document Source Nov 30, 2023

nung22 added 5 commits November 30, 2023 14:55

Merge remote-tracking branch 'upstream' into feature/issue-285

b5d3b30

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

6c25acb

Update merge changes

Move styling to scss file

33e8abe

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

Merge remote-tracking branch 'upstream' into feature/issue-285

2a30185

Update snapshots

fdcc9a1

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

nung22 added 2 commits December 15, 2023 15:15

Merge branch 'feature/issue-285' of https://github.com/nung22/dashboa…

bbc37ce

…rds-search-relevance into feature/issue-285

Update yarn.lock

4e849c5

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

sejli approved these changes Feb 6, 2024

View reviewed changes

sejli requested changes Feb 6, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

Remove unnecessary line in package.json

fde2444

Signed-off-by: Nicholas Ung <nicholasung22@gmail.com>

nung22 commented Mar 10, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

sejli added 2 commits March 18, 2024 15:32

manually updating snapshots for nung22

8a7f075

Signed-off-by: Sean Li <lnse@amazon.com>

resolving conflicts

7744616

Signed-off-by: Sean Li <lnse@amazon.com>

sejli approved these changes Mar 19, 2024

View reviewed changes

sejli merged commit 4e9feca into opensearch-project:main Mar 19, 2024
11 checks passed

sejli added the backport 2.x label Mar 19, 2024

github-actions bot mentioned this pull request Mar 19, 2024

[Backport 2.x] Feature: Add Option to Expand Document Source #378

Merged

nung22 deleted the feature/issue-285 branch March 22, 2024 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: Add Option to Expand Document Source #350

Feature: Add Option to Expand Document Source #350

nung22 commented Nov 6, 2023 •

edited

Loading

codecov bot commented Nov 6, 2023 •

edited

Loading

kgcreative commented Nov 21, 2023

sejli left a comment

nung22 left a comment

Feature: Add Option to Expand Document Source #350

Feature: Add Option to Expand Document Source #350

Conversation

nung22 commented Nov 6, 2023 • edited Loading

Description

Issues Resolved

Screenshots

Source details closed

Source details open

In action

codecov bot commented Nov 6, 2023 • edited Loading

Codecov Report

kgcreative commented Nov 21, 2023

sejli left a comment

Choose a reason for hiding this comment

nung22 left a comment

Choose a reason for hiding this comment

nung22 commented Nov 6, 2023 •

edited

Loading

codecov bot commented Nov 6, 2023 •

edited

Loading