Reporting menu item #295
Merged
Reporting menu item #295
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulderov
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
gulderov
force-pushed
the
reporting-menu-item
branch
from
6196174
to
3874cbe
Compare
Signed-off-by: Danila Gulderov <danila@gulderov.me>
gulderov
force-pushed
the
reporting-menu-item
branch
from
3874cbe
to
267128d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
=======================================
Coverage 74.47% 74.47%
=======================================
Files 30 30
Lines 1904 1904
Branches 410 410
=======================================
Hits 1418 1418
Misses 483 483
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rupal-bq
approved these changes
Feb 16, 2024
|
This is cause due to #118. This bar is likely to change again and the current solution is too flakey to keep buiding on top of it. Else every release this will be a miss |
ps48
approved these changes
Feb 16, 2024
rupal-bq
pushed a commit
that referenced
this pull request
Feb 16, 2024
(cherry picked from commit 58d52f7) Signed-off-by: Danila Gulderov <danila@gulderov.me> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rupal-bq
pushed a commit
that referenced
this pull request
Feb 16, 2024
(cherry picked from commit 58d52f7) Signed-off-by: Danila Gulderov <danila@gulderov.me> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gulderov
added a commit
to gulderov/dashboards-reporting
that referenced
this pull request
Mar 5, 2024
…e-define) (opensearch-project#295) Signed-off-by: Danila Gulderov <danila@gulderov.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues Resolved
Fix #294
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.