Use core navigation instead of hard coding URLs #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
pjfitzgibbons,
ps48,
kavithacm,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
joshuali925
approved these changes
Oct 19, 2023
YANG-DB
approved these changes
Oct 19, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
* Use application navigateToApp instead of window.location.assign Signed-off-by: Derek Ho <dxho@amazon.com> * Remove changes Signed-off-by: Derek Ho <dxho@amazon.com> * Fix formatting Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 8cdb187) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
* Use application navigateToApp instead of window.location.assign Signed-off-by: Derek Ho <dxho@amazon.com> * Remove changes Signed-off-by: Derek Ho <dxho@amazon.com> * Fix formatting Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 8cdb187) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho
pushed a commit
that referenced
this pull request
Oct 19, 2023
derek-ho
pushed a commit
that referenced
this pull request
Oct 19, 2023
70 tasks
Merged
pjfitzgibbons
added a commit
that referenced
this pull request
Nov 27, 2023
#229 is a bugfix, not a feature Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use core navigation instead of hard coding URLs
Issues Resolved
Fix #227
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.