Update breadcrumb title of isDashboardNavMenu #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-project/OpenSearch-Dashboards#4453 Modified the breadcrumbs from the dashboard plugin, to be consistent with the actual name of the application. We should consider not hard checking the name of the breadcrumb but really hooking into the navigation plugin that provides the ability to do what this logic is doing without being hardcoded. opensearch-project#118 Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
|
This will need to be "forward" ported as I created to 2.9 for the sake of time. |
pjfitzgibbons
approved these changes
Jul 12, 2023
rupal-bq
approved these changes
Jul 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
opensearch-project/OpenSearch-Dashboards#4453 Modified the breadcrumbs from the dashboard plugin, to be consistent with the actual name of the application. We should consider not hard checking the name of the breadcrumb but really hooking into the navigation plugin that provides the ability to do what this logic is doing without being hardcoded. #118 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 577871d)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
opensearch-project/OpenSearch-Dashboards#4453 Modified the breadcrumbs from the dashboard plugin, to be consistent with the actual name of the application. We should consider not hard checking the name of the breadcrumb but really hooking into the navigation plugin that provides the ability to do what this logic is doing without being hardcoded. #118 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 577871d)
kavithacm
pushed a commit
that referenced
this pull request
Jul 12, 2023
opensearch-project/OpenSearch-Dashboards#4453 Modified the breadcrumbs from the dashboard plugin, to be consistent with the actual name of the application. We should consider not hard checking the name of the breadcrumb but really hooking into the navigation plugin that provides the ability to do what this logic is doing without being hardcoded. #118 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 577871d) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
kavithacm
pushed a commit
that referenced
this pull request
Jul 12, 2023
opensearch-project/OpenSearch-Dashboards#4453 Modified the breadcrumbs from the dashboard plugin, to be consistent with the actual name of the application. We should consider not hard checking the name of the breadcrumb but really hooking into the navigation plugin that provides the ability to do what this logic is doing without being hardcoded. #118 Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 577871d) Co-authored-by: Kawika Avilla <kavilla414@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opensearch-project/OpenSearch-Dashboards#4453
Modified the breadcrumbs from the dashboard plugin, to be consistent with the actual name of the application.
We should consider not hard checking the name of the breadcrumb but really hooking into the navigation
plugin that provides the ability to do what this
logic is doing without being hardcoded.
This is related to but does not resolve:
#118
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.