[Bug] Fix url redirection, add default render path #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Tackett <tackadam@amazon.com>
ps48
reviewed
Sep 5, 2024
Signed-off-by: Adam Tackett <tackadam@amazon.com>
ps48
reviewed
Sep 5, 2024
Signed-off-by: Adam Tackett <tackadam@amazon.com>
ps48
reviewed
Sep 5, 2024
Signed-off-by: Adam Tackett <tackadam@amazon.com>
TackAdam
requested review from
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
Yury-Fridlyand,
anirudha,
paulstn and
sumukhswamy
as code owners
SuZhou-Joe
reviewed
Sep 6, 2024
| @@ -53,7 +53,7 @@ export const WorkbenchApp = ({ | |||
| <Switch> | |||
| <Route | |||
| exact | |||
| path={`/${basePath}`} | |||
| path={isNavGroupEnabled ? [`${basePath}`, `/`] : `/${basePath}`} | |||
There was a problem hiding this comment.
Suggested change
| path={isNavGroupEnabled ? [`${basePath}`, `/`] : `/${basePath}`} | |
| path={isNavGroupEnabled ? [`${basePath}`, `/`] : `${basePath}`} |
There was a problem hiding this comment.
For the url re-direction to work correctly while the new home page is disabled the "/" is required or the following fail:
path={/${basePath}/:dataSource}
path={/${basePath}/accelerate/:dataSource}
SuZhou-Joe
approved these changes
Sep 6, 2024
ps48
approved these changes
Sep 6, 2024
|
Thanks @TackAdam for the bug fix 🥳 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
* bug fix for url redirection, support for modal popout Signed-off-by: Adam Tackett <tackadam@amazon.com> * change check to isNav Signed-off-by: Adam Tackett <tackadam@amazon.com> * fix formatting lint Signed-off-by: Adam Tackett <tackadam@amazon.com> * simplify router case for empty Signed-off-by: Adam Tackett <tackadam@amazon.com> --------- Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com> (cherry picked from commit 007eabd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 6, 2024
* bug fix for url redirection, support for modal popout Signed-off-by: Adam Tackett <tackadam@amazon.com> * change check to isNav Signed-off-by: Adam Tackett <tackadam@amazon.com> * fix formatting lint Signed-off-by: Adam Tackett <tackadam@amazon.com> * simplify router case for empty Signed-off-by: Adam Tackett <tackadam@amazon.com> --------- Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com> (cherry picked from commit 007eabd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
6 tasks
ps48
pushed a commit
that referenced
this pull request
Sep 10, 2024
* bug fix for url redirection, support for modal popout * change check to isNav * fix formatting lint * simplify router case for empty --------- (cherry picked from commit 007eabd) Signed-off-by: Adam Tackett <tackadam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <tackadam@amazon.com>
ps48
pushed a commit
that referenced
this pull request
Sep 10, 2024
* bug fix for url redirection, support for modal popout * change check to isNav * fix formatting lint * simplify router case for empty --------- (cherry picked from commit 007eabd) Signed-off-by: Adam Tackett <tackadam@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Adam Tackett <tackadam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closing : [navigation] Add default render path when there is basePath #381
(Support for dev tools under modal pop out)
As we will make dev tools as a full page modal when new nav toggle is turned on, we will use MemoryRouter to replace HashRouter in our page to avoid modifying the hosted page' hash. And this change will impact search relevance functionality.
And this PR adds a default path when there is no '/' route.
For more details please take a look on the comment: [navigation] feat: Render dev tools inside a modal OpenSearch-Dashboards#7938 (comment).
Tested url paths:
path={
/${basePath}/:dataSource}path={
/${basePath}/accelerate/:dataSource}path="/"
path={
/${basePath}}Old Navigation:
OldNav4Links.mov
New Navigation:
NewNav4Links.mov
New Navigation + opensearch-project/OpenSearch-Dashboards#7938 modal applied.
NewNav+ModalPopout4Links.mov
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.