Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates create accelerations flyout usage and side tree #285

Merged
merged 9 commits into from
Mar 20, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Mar 19, 2024

Description

Updates create accelerations flyout usage and side tree

Issues Resolved

  1. Updates create accelerations flyout
  2. Uses accelerations details flyout
  3. Updates side is sql to use cache

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.34%. Comparing base (997c666) to head (bcb9c7a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
- Coverage   61.47%   59.34%   -2.13%     
==========================================
  Files          33       39       +6     
  Lines        1599     1835     +236     
  Branches      284      328      +44     
==========================================
+ Hits          983     1089     +106     
- Misses        518      633     +115     
- Partials       98      113      +15     
Flag Coverage Δ
dashboards-query-workbench 59.34% <ø> (-2.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

useEffect(() => {
loadtree();
}, [selectedItems, refreshTree]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. if selectedItems and refreshTree are required dependencies for loadTree, then it's better to explicitly pass them in since you are declared them in dependency array

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 merged commit d168db7 into opensearch-project:main Mar 20, 2024
9 of 13 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-query-workbench/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-query-workbench/backport-2.x
# Create a new branch
git switch --create backport/backport-285-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d168db7402d077681d895309ebe05a50e8880e72
# Push it to GitHub
git push --set-upstream origin backport/backport-285-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-query-workbench/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-285-to-2.x.

ps48 added a commit to ps48/dashboards-query-workbench that referenced this pull request Mar 20, 2024
…roject#285)

* init use observability deps

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update side tree view

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update release notes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* removes console.log

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* allow refresh only after first load

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* revert version to 3.0

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* on umount stop loading

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit d168db7)
ps48 added a commit that referenced this pull request Mar 20, 2024
* init use observability deps

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update side tree view

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update release notes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* removes console.log

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* allow refresh only after first load

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* revert version to 3.0

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* on umount stop loading

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit d168db7)
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.13 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-query-workbench/backport-2.13 2.13
# Navigate to the new working tree
pushd ../.worktrees/dashboards-query-workbench/backport-2.13
# Create a new branch
git switch --create backport/backport-285-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d168db7402d077681d895309ebe05a50e8880e72
# Push it to GitHub
git push --set-upstream origin backport/backport-285-to-2.13
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-query-workbench/backport-2.13

Then, create a pull request where the base branch is 2.13 and the compare/head branch is backport/backport-285-to-2.13.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 20, 2024
* init use observability deps

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update side tree view

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update tests

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update release notes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* removes console.log

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* allow refresh only after first load

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* revert version to 3.0

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* on umount stop loading

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit d168db7)
(cherry picked from commit 754b93e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Mar 20, 2024
…#288)

* init use observability deps



* update side tree view



* update tests



* update release notes



* removes console.log



* allow refresh only after first load



* update snapshots



* revert version to 3.0



* on umount stop loading



---------


(cherry picked from commit d168db7)
(cherry picked from commit 754b93e)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants