Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OSD react as required plugin #278

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Feb 28, 2024

Description

Add OSD react as required plugin

Issues Resolved

Was missed in original PR: #274

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.47%. Comparing base (ca91c6f) to head (603cfa3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   61.47%   61.47%           
=======================================
  Files          33       33           
  Lines        1599     1599           
  Branches      284      284           
=======================================
  Hits          983      983           
  Misses        518      518           
  Partials       98       98           
Flag Coverage Δ
dashboards-query-workbench 61.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding some details in the PR description as to why this is needed/what it is for?

@ps48 ps48 merged commit 7b35161 into opensearch-project:main Feb 28, 2024
14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 28, 2024
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 7b35161)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Feb 28, 2024
(cherry picked from commit 7b35161)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants