Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Bump Cypress Version to 12 #232

Merged

Conversation

RyanL1997
Copy link
Contributor

Description

Upgrade Cypress testing framework from 5.0.0 to 12.8.1

The old existed failure on Cypress 5.0.0:

Screenshot 2023-12-14 at 2 21 05 PM

The current failure on Cypress 12.8.1:

Screenshot 2023-12-14 at 2 34 37 PM

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86c26dd) 53.08% compared to head (82643fc) 53.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #232   +/-   ##
=======================================
  Coverage   53.08%   53.08%           
=======================================
  Files          33       33           
  Lines        1622     1622           
  Branches      288      288           
=======================================
  Hits          861      861           
  Misses        673      673           
  Partials       88       88           
Flag Coverage Δ
dashboards-query-workbench 53.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RyanL1997
Copy link
Contributor Author

Btw I think this one requires manual backport to 2.x too

@ps48 ps48 merged commit 3917540 into opensearch-project:main Dec 14, 2023
9 checks passed
@cwperks
Copy link
Member

cwperks commented Jan 8, 2024

@RyanL1997 I'm not positive, but I think some of the distribution build errors may be related to this PR:

Here's an excerpt:


ERROR [single_version_dependencies] Multiple version ranges for the same dependency

      were found declared across different package.json files. Please consolidate

      those to match across all package.json files. Different versions for the

      same dependency is not supported.



      If you have questions about this please reach out to the operations team.



      The conflicting dependencies are:



        cypress

          ^6.0.0 => opensearch-alerting-dashboards, opensearch_index_management_dashboards, notifications-dashboards, opensearch_security_analytics_dashboards

          ^13.1.0 => customImportMap

          ^12.8.1 => gantt-chart-dashboards, observability-dashboards

          12.8.1 => opensearch-query-workbench

          ^12.8 => reports-dashboards

          ^13.6.0 => opensearch-security-dashboards

        husky

          ^3.0.0 => opensearch-alerting-dashboards, opensearch_index_management_dashboards, opensearch_security_analytics_dashboards

          ^8.0.0 => ml-commons-dashboards

          ^8.0.3 => observability-dashboards

          ^4.2.5 => opensearch-query-workbench

        lint-staged

          ^10.2.0 => opensearch-alerting-dashboards, opensearch_index_management_dashboards, opensearch-query-workbench, opensearch_security_analytics_dashboards

          ^9.2.0 => anomaly-detection-dashboards

          ^10.0.0 => ml-commons-dashboards

          ^13.1.0 => observability-dashboards

        formik

          ^2.2.6 => opensearch-alerting-dashboards, opensearch_security_analytics_dashboards

          ^2.2.5 => anomaly-detection-dashboards

        @testing-library/user-event

          ^12.1.6 => anomaly-detection-dashboards

          ^13.1.9 => opensearch_index_management_dashboards, opensearch-query-workbench, opensearch_security_analytics_dashboards

          ^14.4.3 => ml-commons-dashboards

        @types/react-plotly.js

          ^2.2.4 => anomaly-detection-dashboards, gantt-chart-dashboards

          ^2.5.0 => observability-dashboards

        plotly.js-dist

          ^1.57.1 => anomaly-detection-dashboards, gantt-chart-dashboards

          ^2.2.0 => observability-dashboards

        react-plotly.js

          ^2.4.0 => anomaly-detection-dashboards, gantt-chart-dashboards

          ^2.5.1 => observability-dashboards

        @types/react-test-renderer

          ^18.0.0 => customImportMap

          ^16.9.1 => observability-dashboards, opensearch-query-workbench, reports-dashboards

        cypress-multi-reporters

          ^1.5.0 => customImportMap

          ^1.6.3 => observability-dashboards

        react-graph-vis

          ^1.0.5 => observability-dashboards

          ^1.0.7 => opensearch_security_analytics_dashboards

error Command failed with exit code 1.

All other dashboards plugins use the ^ when declaring the version in package.json. Should query workbench be doing the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants