[BACKPORT 2.x] Log name collision fix #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-project#818) * Add integration name to created index mapping Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Switch template naming to loosely reflect SS4O convention Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Split mapping creation by type for code clarity Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Re-introduce confusing result block Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Modify naming template to better match SS4O convention Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Swiddis
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
penghuo,
seankao-az and
anirudha
as code owners
YANG-DB
approved these changes
Aug 4, 2023
Swiddis
force-pushed
the
backport-log-collision-2x
branch
from
562ecd8
to
5bcd03f
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #838 +/- ##
=======================================
Coverage 43.57% 43.57%
=======================================
Files 313 313
Lines 18620 18620
Branches 4538 4538
=======================================
Hits 8113 8113
Misses 9954 9954
Partials 553 553
Flags with carried forward coverage won't be shown. Click here to find out more. |
derek-ho
approved these changes
Aug 9, 2023
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…-project#818) (opensearch-project#838) * Add integration name to created index mapping * Switch template naming to loosely reflect SS4O convention * Split mapping creation by type for code clarity * Re-introduce confusing result block * Modify naming template to better match SS4O convention --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 8f040ef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #818
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.