Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stylelint issues #634

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix Stylelint issues
Signed-off-by: Matt Provost <provomat@amazon.com>
  • Loading branch information
BSFishy committed Jul 11, 2023
commit e6a43626a5813b741645cf48e3937c1af05f73eb
1 change: 1 addition & 0 deletions public/components/application_analytics/app_analytics.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
overflow: visible;
position: relative;
z-index: 10;

.ppl-link {
top: 103px;
right: 140px;
Expand Down
11 changes: 7 additions & 4 deletions public/components/common/field_button/field_button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,17 @@
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/

.osdFieldButton {
@include euiFontSizeS;

border-radius: $euiBorderRadius;
margin-bottom: $euiSizeXS;
display: flex;
align-items: center;
transition: box-shadow $euiAnimSpeedFast $euiAnimSlightResistance,
background-color $euiAnimSpeedFast $euiAnimSlightResistance; // sass-lint:disable-line indentation
transition:
box-shadow $euiAnimSpeedFast $euiAnimSlightResistance,
background-color $euiAnimSpeedFast $euiAnimSlightResistance;

&:focus-within,
&-isActive {
Expand All @@ -25,6 +27,7 @@
&:focus,
&:focus-within {
@include euiBottomShadowMedium;

border-radius: $euiBorderRadius;
z-index: 2;
}
Expand Down Expand Up @@ -82,7 +85,7 @@
.shard__fieldSelectorField {
&:hover,
&:focus-within,
&[class*='-isActive'] {
&[class*="-isActive"] {
.dscSidebarItem__action {
opacity: 1;
}
Expand Down
18 changes: 11 additions & 7 deletions public/components/common/search/search.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,18 @@

.globalQueryBar {
margin: 0;
padding: .5rem;
padding: 0.5rem;
}

.aa-Autocomplete {
width: 100%;
position: relative;

--aa-search-input-height: 38px;
--aa-panel-border-color-rgb: rgba(227,230,238,255);
--aa-input-background-color-rbg: rgba(250,251,253,255);
--aa-panel-border-color-rgb: rgba(227, 230, 238, 100%);
--aa-input-background-color-rbg: rgba(250, 251, 253, 100%);
}

.styling {
font-weight: bold;
}
Expand All @@ -40,12 +43,12 @@
}

.aa-Panel--scrollable-dark {
background-color: #1D1E24;
background-color: #1d1e24;
border: 2px groove #383444;
}

.aa-Item-dark {
color: #DFE5EF;
color: #dfe5ef;
}

.event-date-picker {
Expand All @@ -59,12 +62,13 @@
right: 15px;
background-color: transparent;
}

.ppl-link-light {
color: #006BB4;
color: #006bb4;
}

.ppl-link-dark {
color: #1BA9F5;
color: #1ba9f5;
}

.base-query-popover {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,16 @@

.mouseGrabber {
& :hover {
cursor: -webkit-grab;
cursor: grab;
}

& :active {
cursor: -webkit-grabbing;
cursor: grabbing;
}
}

.visualization-action-button {
& :hover {
cursor: -webkit-pointer;
cursor: pointer;
}
}
Expand All @@ -37,22 +35,20 @@
%center-div {
top: 50%;
left: 50%;
-ms-transform: translate(-50%, -50%);
-moz-transform: translate(-50%, -50%);
-webkit-transform: translate(-50%, -50%);
-o-transform: translate(-50%, -50%);
transform: translate(-50%, -50%);
}

.visualization-loading-chart {
margin: 0;
position: absolute;

@extend %center-div;
}

.visualization-error-div {
overflow: auto;
position: relative;

@extend %center-div;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,6 @@
position: absolute;
top: 50%;
left: 50%;
-ms-transform: translate(-50%, -50%);
-moz-transform: translate(-50%, -50%);
-webkit-transform: translate(-50%, -50%);
-o-transform: translate(-50%, -50%);
transform: translate(-50%, -50%);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
*/
doc-table {
@include euiScrollBar;

overflow: auto;
flex: 1 1 100%;
flex-direction: column; /* 1 */
Expand Down Expand Up @@ -168,7 +169,7 @@
}

.osdDocTableCell__toggleDetails {
padding: 4px 0 0 0!important;
padding: 4px 0 0 !important;
}

.osdDocTableCell__filter {
Expand Down Expand Up @@ -213,6 +214,7 @@
position: relative;
}
}

discover-app {
flex-grow: 1;
}
Expand All @@ -229,12 +231,13 @@
padding-right: $euiSizeS;
margin-top: $euiSizeM;
z-index: 1;
@include euiBreakpoint('xs', 's', 'm') {

@include euiBreakpoint("xs", "s", "m") {
padding-left: $euiSizeS;
}
}

@include euiPanel('.dscWrapper__content');
@include euiPanel(".dscWrapper__content");

.dscWrapper__content {
padding-top: $euiSizeXS;
Expand Down Expand Up @@ -275,7 +278,6 @@
left: 0;
z-index: 20;
padding-top: $euiSizeM;

opacity: 0.75;
text-align: center;
background-color: transparent;
Expand All @@ -300,7 +302,7 @@

.dscResults {
h3 {
margin: -20px 0 10px 0;
margin: -20px 0 10px;
text-align: center;
}
}
Expand Down Expand Up @@ -340,20 +342,21 @@
z-index: -1;
min-height: $euiSizeM;
min-width: $euiSizeM;
padding: $euiSizeXS * .5;
padding: $euiSizeXS * 0.5;
}

&.closed {
width: 0 !important;
border-right-width: 0;
border-left-width: 0;

.dscCollapsibleSidebar__collapseButton {
right: -$euiSizeL + 4;
}
}
}

@include euiBreakpoint('xs', 's', 'm') {
@include euiBreakpoint("xs", "s", "m") {
.dscCollapsibleSidebar {
&.closed {
display: none;
Expand All @@ -366,6 +369,7 @@
}

/* ------------- Detail table cell -------- */

/**
* 1. Visually align the actions with the tabs. We can improve this by using flexbox instead, at a later point.
*/
Expand All @@ -376,7 +380,6 @@

// Overwrite the border on the bootstrap table
.osdDocTableDetails__row {

> td {
// Offsets negative margins from an inner flex group
padding: $euiSizeL !important;
Expand Down Expand Up @@ -405,12 +408,15 @@
.osdDocTableHeader {
white-space: nowrap;
}

.osdDocTableHeader button {
margin-left: $euiSizeXS;
}

.osdDocTableHeader__move,
.osdDocTableHeader__sortChange {
opacity: 0;

th:hover &,
&:focus {
opacity: 1;
Expand All @@ -433,6 +439,7 @@
vertical-align: top;
padding-top: 2px;
}

.osdDocViewer__field {
padding-top: 8px;
}
Expand Down Expand Up @@ -461,6 +468,7 @@
.osdDocViewer__field {
white-space: nowrap;
}

.osdDocViewer__buttons {
width: 60px;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

.selected-event-row {
background-color: rgba(5, 143, 244, 0.1);
background-color: rgba(5, 143, 244, 10%);
}

.doc-flyout table {
Expand Down Expand Up @@ -38,7 +38,7 @@
.events-flyout-resize {
position: absolute;
right: 30px;
top: 0px;
top: 0;
z-index: 3;
}

Expand Down
2 changes: 1 addition & 1 deletion public/components/event_analytics/explorer/explorer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
*/

.liveStream {
margin : 8px;
margin: 8px;
height: 40px;
align-items: center;
justify-content: center;
Expand Down
6 changes: 4 additions & 2 deletions public/components/event_analytics/explorer/log_explorer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,17 @@
white-space: nowrap;
text-overflow: ellipsis;
}

svg {
vertical-align: inherit;
}

.linkNewTag {
display: inline-block;
text-align: center;
font-size: 0.875rem;
line-height: $tab-new-line-height;
padding: $tab-new-padding; // align with content tab with small size
padding: $tab-new-padding; // align with content tab with small size
min-width: 6rem;
}
}
Expand All @@ -32,4 +34,4 @@

.search-area {
position: relative;
}
}
Loading