[BugFix] Application Analytics - Panels not displaying availability #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TackAdam <navytackett@hotmail.com>
TackAdam
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
Signed-off-by: TackAdam <navytackett@hotmail.com>
Signed-off-by: TackAdam <navytackett@hotmail.com>
derek-ho
reviewed
Jul 7, 2023
Signed-off-by: TackAdam <navytackett@hotmail.com>
Codecov Report
@@ Coverage Diff @@
## main #607 +/- ##
========================================
Coverage 43.42% 43.42%
========================================
Files 300 300
Lines 18113 18115 +2
Branches 4447 4401 -46
========================================
+ Hits 7866 7867 +1
- Misses 9712 10207 +495
+ Partials 535 41 -494
Flags with carried forward coverage won't be shown. Click here to find out more. |
derek-ho
approved these changes
Jul 11, 2023
|
Can you backport to 2.x/2.9 if that's already created |
YANG-DB
approved these changes
Jul 11, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-607-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cd7bf381e65101c873588fdd6e65f185a6e2d295
# Push it to GitHub
git push --set-upstream origin backport/backport-607-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
TackAdam
added a commit
to TackAdam/dashboards-observability
that referenced
this pull request
Jul 11, 2023
[BugFix] Application Analytics - Panels not displaying availability (cherry picked from commit cd7bf38) Signed-off-by: TackAdam <navytackett@hotmail.com>
TackAdam
added a commit
that referenced
this pull request
Jul 11, 2023
[Backport 2.x ] Merge pull request #607
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Fixed a bug where the availability was not being displayed in panels as well as the data configuration. This was due to metaData for the user config not being parsed correctly and always being empty.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.