Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Backport/backport 588 to 2.x #600

Merged

Conversation

mengweieric
Copy link
Collaborator

(cherry picked from commit a85b716)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

anirudha and others added 2 commits June 30, 2023 17:52
…erelease-code-cleanup

(cherry picked from commit a85b716)
Signed-off-by: Eric Wei <menwe@amazon.com>
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #600 (a612aac) into 2.x (449860f) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x     #600      +/-   ##
==========================================
- Coverage   42.74%   42.66%   -0.08%     
==========================================
  Files         299      294       -5     
  Lines       17817    17788      -29     
  Branches     4411     4405       -6     
==========================================
- Hits         7615     7589      -26     
+ Misses      10161     9668     -493     
- Partials       41      531     +490     
Flag Coverage Δ
dashboards-observability 42.66% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 93 files with indirect coverage changes

@mengweieric mengweieric merged commit d329eff into opensearch-project:2.x Jul 5, 2023
@mengweieric mengweieric deleted the backport/backport-588-to-2.x branch July 5, 2023 19:50
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
* Merge pull request opensearch-project#588 from mengweieric/feature/prerelease-code-cleanup

(cherry picked from commit a85b716)

* update snapshots

Signed-off-by: Eric Wei <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
Co-authored-by: Anirudha (Ani) Jadhav <anirudha@nyu.edu>
(cherry picked from commit d329eff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants