Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix Visual update/timestamp save from Panels->LogEvents #522

Merged
merged 1 commit into from
Jun 12, 2023
Merged

BugFix Visual update/timestamp save from Panels->LogEvents #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions public/components/event_analytics/explorer/explorer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,6 @@ export const Explorer = ({
}, [appBasedRef.current]);

useEffect(() => {
if (queryRef.current!.isLoaded) return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of side effects will this have? Extra call? etc. Any possibility for an infinite loop?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of cypress testing for event analytics passing indicates it isn't breaking anything.
Manually testing Dashboards and Application it seems the only extra call is when switching from panel to log events without changing the timestamp, (previously it wasn't updating in any condition).

let objectId;
if (queryRef.current![TAB_CREATED_TYPE] === NEW_TAB || appLogEvents) {
objectId = queryRef.current!.savedObjectId || '';
Expand All @@ -356,7 +355,7 @@ export const Explorer = ({
if (objectId) {
updateTabData(objectId);
} else {
fetchData();
fetchData(startTime, endTime);
}
if (
routerContext &&
Expand Down