Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix saved visualization edit url in visualize #359

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

joshuali925
Copy link
Member

Description

ID in edit url is missing object type

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925
Copy link
Member Author

looks like something broke CI? tests are failing unrelated to my change

Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 joshuali925 merged commit 138fbe1 into opensearch-project:main Apr 17, 2023
joshuali925 added a commit to joshuali925/dashboards-observability that referenced this pull request Apr 17, 2023
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 138fbe1)
joshuali925 added a commit to joshuali925/dashboards-observability that referenced this pull request Apr 17, 2023
Signed-off-by: Joshua Li <joshuali925@gmail.com>
(cherry picked from commit 138fbe1)
pjfitzgibbons pushed a commit that referenced this pull request Apr 17, 2023
Signed-off-by: Joshua Li <joshuali925@gmail.com>
pjfitzgibbons pushed a commit that referenced this pull request Apr 18, 2023
Signed-off-by: Joshua Li <joshuali925@gmail.com>

(cherry picked from commit 138fbe1)
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants