-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left-Nav app registrations for Observability - WIP #350
Conversation
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
2acaa34
to
9e46292
Compare
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
Signed-off-by: Rupal Mahajan <maharup@amazon.com>
* Operational Panels Integrate with Dashboards-List --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com>
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com>
# Conflicts: # .cypress/integration/3_panels.spec.ts # public/components/app.tsx # public/components/custom_panels/home.tsx # public/plugin.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know it's WIP but since we are merging them to main, my question is when do we really review the code change?
.cypress/.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove .DS_Store from git
@@ -18,24 +18,6 @@ import { | |||
|
|||
import { suppressResizeObserverIssue } from '../utils/constants'; | |||
|
|||
const moveToEventsHome = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are we using cypress from https://github.com/opensearch-project/opensearch-dashboards-functional-test/ repo or here?
cypress.json
Outdated
@@ -1,5 +1,5 @@ | |||
{ | |||
"baseUrl": "http://localhost:5601", | |||
"baseUrl": "http://localhost:5602", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why 5602
* Left Nav links. Working for Notebook. * Remove observability side bar * Events URL working * Fix metrics link from left nav * Fix applications link --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com>
…t#350) * Left Nav links. Working for Notebook. * Remove observability side bar * Events URL working * Fix metrics link from left nav * Fix applications link --------- Signed-off-by: Peter Fitzgibbons <pjfitz@amazon.com> Signed-off-by: Rupal Mahajan <maharup@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Co-authored-by: Peter Fitzgibbons <pjfitz@amazon.com> Co-authored-by: Rupal Mahajan <maharup@amazon.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Derek Ho <dxho@amazon.com>
Description
Modify Observability plugin registration to make Observability a "top level" grouping on the OSD Left Navigation fly-out.
The P3/P4 result will look like :
Our P1 goal is only the Observability Grouping :
Applications
Logs
Metrics
Traces
Notebooks
Note that Traces does not have an indpendent module at this time.
Also note that "Logs" is our current Event Explorer
The "Observability" link under the "OpenSearch Plugins" group will remain, with it's default page-link as Event Explorer.
Issues Resolved
resolves #34
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.