Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CVE fix for ag #1989

Merged
merged 5 commits into from
Jul 24, 2024
Merged

[Bug] CVE fix for ag #1989

merged 5 commits into from
Jul 24, 2024

Conversation

TackAdam
Copy link
Collaborator

@TackAdam TackAdam commented Jul 24, 2024

Description

"@ag-grid-community/styles": "^32.0.2" to => "^31.3.4"

  • Fixes Dashboards-Observability in main, the issue with the previous PR is upgrading to version 32 leads to package compilation failures. Hence, moving it back to latest of version 31 which has the CVE patched.
│          ERROR in ./node_modules/ag-grid-react/dist/package/index.cjs.js 284:49
       │          Module parse failed: Unexpected token (284:49)
       │          You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
       │          |       className,
       │          |       ref: setRef2,
       │          >       ...!props.colDef ? { role: ctrlRef.current?.getCellAriaRole() } : {}
       │          |     },
       │          |     /* @__PURE__ */ import_react2.default.createElement("span", { className: expandedClassName, ref: eExpandedRef }),
       │           @ ./public/components/visualizations/charts/data_table/data_table.tsx 10:0-44 174:39-50 198:90-101
       │           @ ./public/components/event_analytics/explorer/visualizations/workspace_panel/workspace_panel.tsx
       │           @ ./public/components/event_analytics/explorer/visualizations/workspace_panel/index.ts
       │           @ ./public/components/event_analytics/explorer/visualizations/index.tsx
       │           @ ./public/components/event_analytics/explorer/explorer.tsx
       │           @ ./public/components/event_analytics/explorer/log_explorer.tsx
       │           @ ./public/components/event_analytics/index.tsx
       │           @ ./public/components/app.tsx
       │           @ ./public/components/index.tsx
       │           @ ./public/plugin.tsx
       │           @ ./public/index.ts

Issues Resolved

CVE-2024-39001

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Adam Tackett added 3 commits July 24, 2024 11:43
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 merged commit 196dd35 into opensearch-project:main Jul 24, 2024
14 of 24 checks passed
TackAdam added a commit to TackAdam/dashboards-observability that referenced this pull request Jul 24, 2024
* update package to fix CVEs

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* include yarnlock

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* change ag for cve

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update release notes

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 196dd35)
TackAdam added a commit to TackAdam/dashboards-observability that referenced this pull request Jul 24, 2024
* update package to fix CVEs

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* include yarnlock

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* change ag for cve

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update release notes

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 196dd35)
ps48 pushed a commit that referenced this pull request Jul 24, 2024
* [Bug] CVE fix for ag (#1989)

* update package to fix CVEs

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* include yarnlock

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* change ag for cve

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update release notes

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 196dd35)

* backport cve

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update depend

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update snapshots

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
@TackAdam
Copy link
Collaborator Author

Backports to 2.x and 2.16 handled with:
#1990
#1991

ps48 pushed a commit that referenced this pull request Jul 24, 2024
* [Bug] CVE fix for ag (#1989)

* update package to fix CVEs

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* include yarnlock

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* change ag for cve

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update release notes

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 196dd35)

* backport cve1

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update snapshots

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update snapshots

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
sumukhswamy pushed a commit that referenced this pull request Jul 29, 2024
* [Bug] CVE fix for ag (#1989)

* update package to fix CVEs

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* include yarnlock

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* change ag for cve

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update release notes

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 196dd35)

* backport cve

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update depend

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update snapshots

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* [Bug] Remove ag grid package (#2001)

* remove ag grid

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update yarn lock

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update release notes

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
(cherry picked from commit 805c54f)

* quick fix

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* remove ag

Signed-off-by: Adam Tackett <tackadam@amazon.com>

* update snapshots, remove securrity lakes from integrations, add import

Signed-off-by: Adam Tackett <tackadam@amazon.com>

---------

Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <105462877+TackAdam@users.noreply.github.com>
Co-authored-by: Adam Tackett <tackadam@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants