Add auto-suggestions for skipping index definition and export types #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ps48
requested review from
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsimanohar,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1552 +/- ##
==========================================
+ Coverage 57.83% 57.86% +0.02%
==========================================
Files 366 367 +1
Lines 13666 13734 +68
Branches 3573 3595 +22
==========================================
+ Hits 7904 7947 +43
- Misses 5700 5723 +23
- Partials 62 64 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ps48
force-pushed
the
auto_skipping_index
branch
from
2274d7c to
f1aef4f
Compare
Swiddis
approved these changes
Mar 19, 2024
| return; | ||
| } | ||
| setSQLcode(accelerationQueryBuilder(accelerationFormData)); | ||
| setIsPreviewStale(false); | ||
| setIsPreviewTriggered(true); | ||
| }; | ||
|
|
||
| const checkIfSQLWorkbenchPluginIsInstalled = () => { | ||
| fetch('../api/status', { |
There was a problem hiding this comment.
Should this not be http.get?
There was a problem hiding this comment.
This is not fetching from a route rather using dashboards status API.
|
please resolve conflicts. |
mengweieric
approved these changes
Mar 19, 2024
RyanL1997
approved these changes
Mar 19, 2024
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| 'osd-xsrf': 'true', | ||
| 'accept-language': 'en-US,en;q=0.9,zh-CN;q=0.8,zh;q=0.7,zh-TW;q=0.6', |
There was a problem hiding this comment.
just for my knowledge why do we need this in the header, isn't this for the .i18nrc?
There was a problem hiding this comment.
that's a header added to request to accept responses in different languages
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48
force-pushed
the
auto_skipping_index
branch
from
f1aef4f to
a580089
Compare
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 19, 2024
…1552) * add generate modal and status check for workbench Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove debug logs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * expose types for cachemanager Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * rebase changes Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 6dfafbd) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
added a commit
that referenced
this pull request
Mar 19, 2024
…1552) (#1569) * add generate modal and status check for workbench * remove debug logs * expose types for cachemanager * rebase changes --------- (cherry picked from commit 6dfafbd) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…pensearch-project#1552) (opensearch-project#1569) * add generate modal and status check for workbench * remove debug logs * expose types for cachemanager * rebase changes --------- (cherry picked from commit 6dfafbd) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit dc0245f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add auto-suggestions for skipping index definition and export types
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.