Adding datasource status and filter for hive tables #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48
requested review from
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
anirudha,
paulstn and
sumukhswamy
as code owners
paulstn
reviewed
Mar 16, 2024
public/components/datasources/components/manage/manage_data_connections_table.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1549 +/- ##
==========================================
- Coverage 57.96% 57.86% -0.11%
==========================================
Files 363 364 +1
Lines 13332 13363 +31
Branches 3467 3472 +5
==========================================
+ Hits 7728 7732 +4
- Misses 5545 5572 +27
Partials 59 59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mengweieric
approved these changes
Mar 16, 2024
| }; | ||
|
|
||
| return ( | ||
| <EuiCallOut title="This data source connection is inactive" color="warning" iconType="help"> |
There was a problem hiding this comment.
please add i18n here and below user facing text
There was a problem hiding this comment.
ack. I was talking to Paul about it we should have a meta issue for all of dashboards-observability to follow i18n.
#1539
paulstn
approved these changes
Mar 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 16, 2024
* adding datasource status and filter for hive tables Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update tests and replace dataConnection variable Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 0e7c2bf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Mar 16, 2024
* adding datasource status and filter for hive tables * update tests and replace dataConnection variable --------- (cherry picked from commit 0e7c2bf) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
…ct#1549) (opensearch-project#1550) * adding datasource status and filter for hive tables * update tests and replace dataConnection variable --------- (cherry picked from commit 0e7c2bf) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit d563366)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding datasource status and filter for hive tables
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.