Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Sources: Installed Integrations Table #1530

Closed

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Mar 13, 2024

Description

First PR in a coming series adding installed integrations to the data sources viewer. Some WIP upcoming parts:

  • Snapshot Tests
  • Search Bar
  • Loading integrations to the table dynamically (need to add linked data source(s) to the integration instance fields).
  • Adding action buttons on the right
  • Empty state
image

This PR is mostly here to help get some initial work in for preliminary looks at the 2.13 release, but isn't release-ready yet so I'll hold off on the backport label for now.

Issues Resolved

N/A (need to write an issue for the feature).

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis Swiddis changed the title Stub installed integrations table for data sources Data Sources: Installed Integrations Table Mar 14, 2024
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis Swiddis added enhancement New feature or request integrations Used to denote items related to the Integrations project labels Mar 14, 2024
@Swiddis
Copy link
Collaborator Author

Swiddis commented Mar 14, 2024

Marking ready for review -- Still not going to backport until the remainder of the necessary work is done but it's usable in the current state

case 'partially-available':
return <EuiHealth color="warning">Partially Available</EuiHealth>;
default:
return <EuiHealth color="danger">Critical</EuiHealth>;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: it might be worthwhile to make a string enum for the status type and comprehensively cover all the branches, using default for critical is tech debt

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis
Copy link
Collaborator Author

Swiddis commented Mar 14, 2024

Test failures are upstream OSD breakage, looks like the culprit is opensearch-project/OpenSearch-Dashboards#6060.

Fix: #1533

Lint issues are also happening, tracking issue here: #1363.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 78.12500% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 57.04%. Comparing base (a07b3c1) to head (b0d55e7).

❗ Current head b0d55e7 differs from pull request most recent head 9332048. Consider uploading reports for the commit 9332048 to get more accurate results

Files Patch % Lines
...ents/integrations/components/added_integration.tsx 60.00% 4 Missing ⚠️
...nage/integrations/installed_integrations_table.tsx 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1530      +/-   ##
==========================================
- Coverage   57.74%   57.04%   -0.70%     
==========================================
  Files         362      349      -13     
  Lines       13301    12729     -572     
  Branches     3461     3278     -183     
==========================================
- Hits         7680     7261     -419     
+ Misses       5562     5414     -148     
+ Partials       59       54       -5     
Flag Coverage Δ
dashboards-observability 57.04% <78.12%> (-0.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis
Copy link
Collaborator Author

Swiddis commented Mar 16, 2024

Accidentally merged #1544 first -- Since that PR is a superset of this one I'll close this one and make a followup for issues

@Swiddis Swiddis closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request integrations Used to denote items related to the Integrations project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants