Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor integration name updates #1505

Merged
merged 3 commits into from
Mar 9, 2024
Merged

Minor integration name updates #1505

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4d7216
Rename asset name to integration name
Swiddis Mar 8, 2024
e1a790c
Update integration schema fields name
Swiddis Mar 8, 2024
a78bad7
Merge branch 'main' into feature/name-updates
Swiddis Mar 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Rename asset name to integration name 
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
  • Loading branch information
@Swiddis
Swiddis committed Mar 8, 2024
commit c4d7216ab687fdd7fffad887d8c940900d8fdb91
14 changes: 7 additions & 7 deletions ...nts/integrations/components/__tests__/__snapshots__/added_integration_table.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ exports[`Added Integration Table View Test Renders added integration table view
Array [
Object {
"field": "name",
"name": "Asset name",
"name": "Integration Name",
"render": [Function],
"sortable": true,
"truncateText": true,
Expand Down Expand Up @@ -558,7 +558,7 @@ exports[`Added Integration Table View Test Renders added integration table view
Array [
Object {
"field": "name",
"name": "Asset name",
"name": "Integration Name",
"render": [Function],
"sortable": true,
"truncateText": true,
Expand Down Expand Up @@ -707,15 +707,15 @@ exports[`Added Integration Table View Test Renders added integration table view
values={
Object {
"description": undefined,
"innerText": "Asset name",
"innerText": "Integration Name",
}
}
>
<span
className="euiTableCellContent__text"
title="Asset name"
title="Integration Name"
>
Asset name
Integration Name
</span>
</EuiI18n>
</EuiInnerText>
Expand Down Expand Up @@ -880,7 +880,7 @@ exports[`Added Integration Table View Test Renders added integration table view
key="_data_column_name_ad7e6e30-0b99-11ee-b27c-c9863222e9bf_0"
mobileOptions={
Object {
"header": "Asset name",
"header": "Integration Name",
"render": undefined,
}
}
Expand All @@ -899,7 +899,7 @@ exports[`Added Integration Table View Test Renders added integration table view
<div
className="euiTableRowCell__mobileHeader euiTableRowCell--hideForDesktop"
>
Asset name
Integration Name
</div>
<div
className="euiTableCellContent euiTableCellContent--truncateText euiTableCellContent--overflowingContent"
Expand Down
11 changes: 7 additions & 4 deletions public/components/integrations/components/added_integration_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ import {
} from '@elastic/eui';
import _ from 'lodash';
import React, { useState } from 'react';
import { AddedIntegrationsTableProps } from './added_integration_overview_page';
import {
AddedIntegrationType,
AddedIntegrationsTableProps,
} from './added_integration_overview_page';
import { DeleteModal } from '../../../../public/components/common/helpers/delete_modal';
import { INTEGRATIONS_BASE } from '../../../../common/constants/shared';
import { useToast } from '../../../../public/components/common/toast';
Expand All @@ -33,7 +36,7 @@ export function AddedIntegrationsTable(props: AddedIntegrationsTableProps) {
const tableColumns = [
{
field: 'name',
name: 'Asset name',
name: 'Integration Name',
sortable: true,
truncateText: true,
render: (value, record) => (
Expand Down Expand Up @@ -81,7 +84,7 @@ export function AddedIntegrationsTable(props: AddedIntegrationsTableProps) {
/>
),
},
] as Array<EuiTableFieldDataColumnType<any>>;
] as Array<EuiTableFieldDataColumnType<AddedIntegrationType>>;

async function deleteAddedIntegration(integrationInstance: string, name: string) {
http
Expand All @@ -92,7 +95,7 @@ export function AddedIntegrationsTable(props: AddedIntegrationsTableProps) {
hits: props.data.hits.filter((i) => i.id !== integrationInstance),
});
})
.catch((err) => {
.catch((_err) => {
setToast(`Error deleting ${name} or its assets`, 'danger');
})
.finally(() => {
Expand Down