Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport main] [BUG] Fixing style overriding issue in dashboards core vizBuilder #1453

Merged
merged 1 commit into from
Feb 20, 2024
Merged

[Backport main] [BUG] Fixing style overriding issue in dashboards core vizBuilder #1453

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...r/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
}
}

.vbConfig {
.logExplorerVisConfig {
@include euiYScrollWithShadows;

background: $euiColorLightestShade;
Expand Down Expand Up @@ -82,7 +82,7 @@
}
}

&.showSecondary > .vbConfig__section {
&.showSecondary > .logExplorerVisConfig__section {
transform: translateX(-100%);
}
}
12 changes: 6 additions & 6 deletions ...er/visualizations/config_panel/config_panes/config_controls/data_configurations_panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ export const DataConfigPanelItem = ({
const selectedObj = isTimeStampSelected ? configList[SPAN] : configList[name][index];
const isAggregations = name === AGGREGATIONS;
return (
<div className={'vbConfig__section vbConfig--secondary'}>
<div className={'logExplorerVisConfig__section logExplorerVisConfig--secondary'}>
<div className="services">
<div className="first-division">
<DataConfigItemClickPanel
Expand Down Expand Up @@ -538,9 +538,9 @@ export const DataConfigPanelItem = ({
return isAddConfigClicked ? (
getCommonUI(selectedConfigItem.name)
) : (
<EuiForm className={'vbConfig'}>
<div className="vbConfig__section">
<div className="vbConfig__title">
<EuiForm className={'logExplorerVisConfig'}>
<div className="logExplorerVisConfig__section">
<div className="logExplorerVisConfig__title">
<EuiFlexGroup gutterSize="s" alignItems="center">
<EuiFlexItem>
<EuiTitle size="xxs">
Expand All @@ -550,7 +550,7 @@ export const DataConfigPanelItem = ({
</EuiFlexGroup>
</div>
{visualizations.vis.name !== VIS_CHART_TYPES.Histogram ? (
<div className="vbConfig__content">
<div className="logExplorerVisConfig__content">
<EuiSpacer size="s" />
{DataConfigPanelFields(getRenderFieldsObj(AGGREGATIONS))}
<EuiHorizontalRule margin="m" />
Expand All @@ -577,7 +577,7 @@ export const DataConfigPanelItem = ({
{getNumberField('bucketOffset')}
</>
)}
<div className="vbConfig__content">
<div className="logExplorerVisConfig__content">
<EuiFlexItem grow={false}>
<EuiButton
data-test-subj="visualizeEditorRenderButton"
Expand Down
18 changes: 18 additions & 0 deletions ...grations/components/__tests__/__snapshots__/available_integration_card_view.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ exports[`Available Integration Card View Test Renders nginx integration card vie
className="euiButtonContent__icon"
color="inherit"
size="m"
title="list"
type="list"
>
<EuiIconBeaker
Expand All @@ -279,9 +280,12 @@ exports[`Available Integration Card View Test Renders nginx integration card vie
focusable="false"
role="img"
style={null}
title="list"
titleId="random_html_id"
>
<svg
aria-hidden={true}
aria-labelledby="random_html_id"
className="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height={16}
Expand All @@ -291,6 +295,11 @@ exports[`Available Integration Card View Test Renders nginx integration card vie
width={16}
xmlns="http://www.w3.org/2000/svg"
>
<title
id="random_html_id"
>
list
</title>
<path
d="M5.277 10.088c.02.014.04.03.057.047.582.55 1.134.812 1.666.812.586 0 1.84-.293 3.713-.88L9 6.212V2H7v4.212l-1.723 3.876Zm-.438.987L3.539 14h8.922l-1.32-2.969C9.096 11.677 7.733 12 7 12c-.74 0-1.463-.315-2.161-.925ZM6 2H5V1h6v1h-1v4l3.375 7.594A1 1 0 0 1 12.461 15H3.54a1 1 0 0 1-.914-1.406L6 6V2Z"
/>
Expand Down Expand Up @@ -384,6 +393,7 @@ exports[`Available Integration Card View Test Renders nginx integration card vie
className="euiButtonContent__icon"
color="inherit"
size="m"
title="grid"
type="grid"
>
<EuiIconBeaker
Expand All @@ -392,9 +402,12 @@ exports[`Available Integration Card View Test Renders nginx integration card vie
focusable="false"
role="img"
style={null}
title="grid"
titleId="random_html_id"
>
<svg
aria-hidden={true}
aria-labelledby="random_html_id"
className="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height={16}
Expand All @@ -404,6 +417,11 @@ exports[`Available Integration Card View Test Renders nginx integration card vie
width={16}
xmlns="http://www.w3.org/2000/svg"
>
<title
id="random_html_id"
>
grid
</title>
<path
d="M5.277 10.088c.02.014.04.03.057.047.582.55 1.134.812 1.666.812.586 0 1.84-.293 3.713-.88L9 6.212V2H7v4.212l-1.723 3.876Zm-.438.987L3.539 14h8.922l-1.32-2.969C9.096 11.677 7.733 12 7 12c-.74 0-1.463-.315-2.161-.925ZM6 2H5V1h6v1h-1v4l3.375 7.594A1 1 0 0 1 12.461 15H3.54a1 1 0 0 1-.914-1.406L6 6V2Z"
/>
Expand Down
18 changes: 18 additions & 0 deletions ...rations/components/__tests__/__snapshots__/available_integration_table_view.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,6 +473,7 @@ exports[`Available Integration Table View Test Renders nginx integration table v
className="euiButtonContent__icon"
color="inherit"
size="m"
title="list"
type="list"
>
<EuiIconBeaker
Expand All @@ -481,9 +482,12 @@ exports[`Available Integration Table View Test Renders nginx integration table v
focusable="false"
role="img"
style={null}
title="list"
titleId="random_html_id"
>
<svg
aria-hidden={true}
aria-labelledby="random_html_id"
className="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height={16}
Expand All @@ -493,6 +497,11 @@ exports[`Available Integration Table View Test Renders nginx integration table v
width={16}
xmlns="http://www.w3.org/2000/svg"
>
<title
id="random_html_id"
>
list
</title>
<path
d="M5.277 10.088c.02.014.04.03.057.047.582.55 1.134.812 1.666.812.586 0 1.84-.293 3.713-.88L9 6.212V2H7v4.212l-1.723 3.876Zm-.438.987L3.539 14h8.922l-1.32-2.969C9.096 11.677 7.733 12 7 12c-.74 0-1.463-.315-2.161-.925ZM6 2H5V1h6v1h-1v4l3.375 7.594A1 1 0 0 1 12.461 15H3.54a1 1 0 0 1-.914-1.406L6 6V2Z"
/>
Expand Down Expand Up @@ -586,6 +595,7 @@ exports[`Available Integration Table View Test Renders nginx integration table v
className="euiButtonContent__icon"
color="inherit"
size="m"
title="grid"
type="grid"
>
<EuiIconBeaker
Expand All @@ -594,9 +604,12 @@ exports[`Available Integration Table View Test Renders nginx integration table v
focusable="false"
role="img"
style={null}
title="grid"
titleId="random_html_id"
>
<svg
aria-hidden={true}
aria-labelledby="random_html_id"
className="euiIcon euiIcon--medium euiIcon--inherit euiIcon-isLoading euiButtonContent__icon"
focusable="false"
height={16}
Expand All @@ -606,6 +619,11 @@ exports[`Available Integration Table View Test Renders nginx integration table v
width={16}
xmlns="http://www.w3.org/2000/svg"
>
<title
id="random_html_id"
>
grid
</title>
<path
d="M5.277 10.088c.02.014.04.03.057.047.582.55 1.134.812 1.666.812.586 0 1.84-.293 3.713-.88L9 6.212V2H7v4.212l-1.723 3.876Zm-.438.987L3.539 14h8.922l-1.32-2.969C9.096 11.677 7.733 12 7 12c-.74 0-1.463-.315-2.161-.925ZM6 2H5V1h6v1h-1v4l3.375 7.594A1 1 0 0 1 12.461 15H3.54a1 1 0 0 1-.914-1.406L6 6V2Z"
/>
Expand Down
Loading