Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] Backport linter CI to 2.x #1313

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

mengweieric
Copy link
Collaborator

Description

#1301

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd55726) 57.44% compared to head (f62fe99) 57.44%.
Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #1313      +/-   ##
==========================================
- Coverage   57.44%   57.44%   -0.01%     
==========================================
  Files         330      330              
  Lines       12094    12099       +5     
  Branches     2793     2791       -2     
==========================================
+ Hits         6948     6950       +2     
- Misses       5100     5103       +3     
  Partials       46       46              
Flag Coverage Δ
dashboards-observability 57.44% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric mengweieric merged commit 138bd21 into opensearch-project:2.x Dec 20, 2023
8 of 17 checks passed
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
* linter CI (opensearch-project#1301)

Signed-off-by: Eric <menwe@amazon.com>

* change version to 2.x

Signed-off-by: Eric <menwe@amazon.com>

* add missing scripts

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
(cherry picked from commit 138bd21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants