Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version in integration tests workflow #1260

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Nov 17, 2023

Description

Resolving an old todo, in response to the breaking upstream bootstrap change that is causing our CI to fail bootstrap.

Issues Resolved

Part of longstanding work on #1040

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis
Copy link
Collaborator Author

Swiddis commented Nov 17, 2023

Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
@Swiddis Swiddis requested a review from ps48 November 17, 2023 21:18
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43a044f) 44.06% compared to head (504be54) 44.06%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1260   +/-   ##
=======================================
  Coverage   44.06%   44.06%           
=======================================
  Files         329      329           
  Lines       19682    19682           
  Branches     4685     4685           
=======================================
  Hits         8673     8673           
  Misses      10964    10964           
  Partials       45       45           
Flag Coverage Δ
dashboards-observability 44.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swiddis Swiddis merged commit 194555f into opensearch-project:main Nov 27, 2023
9 checks passed
@Swiddis Swiddis deleted the fix-node-ci-version branch November 27, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants