Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricGrid - enable drag/drop ordering of metric panels #1168

Conversation

pjfitzgibbons
Copy link
Contributor

Description

Enable drag/drop ordering of metric panels
Also change redux metric-slice metrics-list to use map (keyBy id)

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

- change redux metric-slice metrics-list to use map (keyBy id)

Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1168 (0c5531f) into refactor/metric-save-as-ppl (37a963b) will decrease coverage by 0.23%.
Report is 1 commits behind head on refactor/metric-save-as-ppl.
The diff coverage is n/a.

@@                       Coverage Diff                       @@
##           refactor/metric-save-as-ppl    #1168      +/-   ##
===============================================================
- Coverage                        44.02%   43.79%   -0.23%     
===============================================================
  Files                              329      329              
  Lines                            19554    19527      -27     
  Branches                          4733     4729       -4     
===============================================================
- Hits                              8608     8552      -56     
- Misses                           10378    10404      +26     
- Partials                           568      571       +3     
Flag Coverage Δ
dashboards-observability 43.79% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@pjfitzgibbons pjfitzgibbons deleted the refactor/metric-grid-drag-drop-4 branch November 9, 2023 23:33
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…) (opensearch-project#1168)

Signed-off-by: Yan Zeng <zengyan@amazon.com>

Co-authored-by: Chang Liu <lc12251109@gmail.com>
(cherry picked from commit 6236fe2a34f06fd2c104f4b7f86cfce4e55d761d)

Co-authored-by: Yan Zeng <46499415+zengyan-amazon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant