code cleanup

Signed-off-by: Derek Ho <dxho@amazon.com>
opensearch-project · Apr 27, 2023 · dbc7976 · dbc7976
1 parent f62f1b8
commit dbc7976
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 8 deletions.
diff --git a/public/components/custom_panels/custom_panel_table.tsx b/public/components/custom_panels/custom_panel_table.tsx
@@ -124,7 +124,7 @@ export const CustomPanelTable = ({
       setToast('Invalid Dashboard name', 'danger');
     } else {
       const newPanel = newPanelTemplate(newCustomPanelName);
-      dispatch(createPanel(newPanel, setToast));
+      dispatch(createPanel(newPanel));
     }
     closeModal();
   };
@@ -158,7 +158,7 @@ export const CustomPanelTable = ({
           title: newName,
         };
 
-        dispatch(createPanel(newPanel, setToast));
+        dispatch(createPanel(newPanel));
       } catch (err) {
         setToast(
           'Error cloning Observability Dashboard, please make sure you have the correct permission.',

diff --git a/public/components/custom_panels/custom_panel_view_so.tsx b/public/components/custom_panels/custom_panel_view_so.tsx
@@ -66,7 +66,7 @@ import {
 import { useToast } from '../common/toast';
 import PPLService from '../../services/requests/ppl';
 import DSLService from '../../services/requests/dsl';
-
+ 
 /*
  * "CustomPanelsView" module used to render an Observability Dashboard
  *
@@ -258,10 +258,27 @@ export const CustomPanelViewSO = (props: CustomPanelViewProps) => {
   };
 
   // toggle between panel edit mode
+<<<<<<< HEAD
   const editPanel = (editType: string) => {
     setIsEditing(!isEditing);
     if (editType === 'cancel') dispatch(fetchPanel(panelId));
     setEditActionType(editType);
+=======
+
+  const startEdit = () => {
+    setIsEditing(true);
+  };
+
+  const applyEdits = useCallback(() => {
+    dispatch(updatePanel(panel, '', ''));
+    setIsEditing(false);
+    setEditActionType('save');
+  }, [panel]);
+
+  const cancelEdit = () => {
+    dispatch(fetchPanel(panelId));
+    setIsEditing(false);
+>>>>>>> 22977feb (code cleanup)
   };
 
   const closeFlyout = () => {
@@ -446,7 +463,6 @@ export const CustomPanelViewSO = (props: CustomPanelViewProps) => {
         pplFilterValue={pplFilterValue}
         start={panel.timeRange.from}
         end={panel.timeRange.to}
-        setToast={setToast}
         http={coreRefs.http!}
         pplService={pplService}
         setPanelVisualizations={setPanelVisualizations}

diff --git a/...c/components/custom_panels/panel_modules/visualization_flyout/visualization_flyout_so.tsx b/...c/components/custom_panels/panel_modules/visualization_flyout/visualization_flyout_so.tsx
@@ -92,16 +92,12 @@ interface VisualizationFlyoutSOProps {
 }
 
 export const VisaulizationFlyoutSO = ({
-  panelId,
   appId = '',
   pplFilterValue,
   closeFlyout,
   start,
   end,
-  http,
-  savedObjects,
   pplService,
-  setPanelVisualizations,
   isFlyoutReplacement,
   replaceVisualizationId,
   addVisualizationPanel,