-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the MAINTAINERS.md file #42
Conversation
Signed-off-by: bbarani <bbarani@amazon.com>
@SuZhou-Joe Please merge this PR when you get time. I have fixed permissions in this repo. |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage ? 86.54%
=======================================
Files ? 51
Lines ? 1479
Branches ? 352
=======================================
Hits ? 1280
Misses ? 196
Partials ? 3
Flags with carried forward coverage won't be shown. Click here to find out more. |
MAINTAINERS.md
Outdated
| Hailong Cui | [Hailong-am](https://github.com/Hailong-am) | Amazon | | ||
| Binlong Gao | [gaobinlong](https://github.com/gaobinlong) | Amazon | | ||
| Zhou Su | [SuZhou-Joe](https://github.com/SuZhou-Joe) | Amazon | | ||
| Yuye Zhu | [SuZhou-Joe](https://github.com/yuye-aws) | Amazon | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github ID should be yuye-aws, not SuZhou-Joe
MAINTAINERS.md
Outdated
| Binlong Gao | [gaobinlong](https://github.com/gaobinlong) | Amazon | | ||
| Zhou Su | [SuZhou-Joe](https://github.com/SuZhou-Joe) | Amazon | | ||
| Yuye Zhu | [SuZhou-Joe](https://github.com/yuye-aws) | Amazon | | ||
| zhichao | [SuZhou-Joe](https://github.com/zhichao-aws) | Amazon | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name is Zhichao Geng, Github id should be zhichao-aws, not SuZhou-Joe
Co-authored-by: suzhou <suzhou@amazon.com> Signed-off-by: Xuesong Luo <lxuesong@amazon.com>
Signed-off-by: suzhou <suzhou@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-notifications/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-notifications/backport-2.x
# Create a new branch
git switch --create backport/backport-42-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9fd0ad9b8dc670e1e6a479131e766375cf599a39
# Push it to GitHub
git push --set-upstream origin backport/backport-42-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-notifications/backport-2.x Then, create a pull request where the |
Description
Updated the MAINTAINERS.md file
Issues Resolved
Closes #31
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.