Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integ tests for denied ips for Custom webhook #286

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Integ tests for denied ips for Custom webhook #286

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f89a9cc
integ tests for denied ips
riysaxen-amzn Sep 27, 2024
926113c
integ tests for denied ips
riysaxen-amzn Sep 27, 2024
b7a8891
integ tests for denied ips
riysaxen-amzn Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 66 additions & 1 deletion .cypress/integration/channels.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,71 @@ describe('Test create channels', () => {
cy.contains('successfully created.').should('exist');
});

const updateLocalClusterSettings = (denyList) => {
cy.request({
method: 'PUT',
url: 'http://localhost:9200/_cluster/settings',
body: {
persistent: {
opensearch: {
notifications: {
core: {
http: {
host_deny_list: denyList,
},
},
},
},
},
},
}).then((response) => {
expect(response.status).to.eq(200);
expect(response.body).to.have.property('acknowledged', true);
});
};

it('sends a test message for denied IPs', () => {
const deniedIps = [
'127.0.0.1',
'169.254.0.1',
'10.0.0.1',
'255.255.255.255'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add one more hostname?

];

updateLocalClusterSettings(deniedIps);

cy.get('[placeholder="Enter channel name"]').type('Test denied webhook channels');

cy.get('.euiSuperSelectControl').contains('Slack').click({ force: true });
cy.wait(delay);
// Optionally, add a check to ensure the dropdown options are visible/loaded
cy.get('.euiContextMenuItem__text').should('be.visible');
cy.get('.euiContextMenuItem__text')
.contains('Custom webhook')
.click({ force: true });
cy.wait(delay);

deniedIps.forEach(ip => {
// Constructing the custom webhook URL for each IP
const webhookUrl = `https://${ip}:8888/test-path?params1=value1&params2=value2&params3=value3&params4=value4&params5=values5&params6=values6&params7=values7`;

cy.get('[data-test-subj="custom-webhook-url-input"]').clear().type(webhookUrl);

// Send the test message
cy.get('[data-test-subj="create-channel-send-test-message-button"]').click({
force: true,
});
cy.wait(delay);

// Check for the expected error message indicating the host is denied
cy.contains('Failed to send the test message').should('exist');
cy.get('.euiButton__text').should('be.visible');
cy.get('.euiButton__text').contains('See the full error').click({ force: true });
cy.contains('Host of url is denied').should('exist');
cy.get('.euiButton__text').contains('Close').click({ force: true });
});
});

it('creates an sns channel', () => {
cy.get('[placeholder="Enter channel name"]').type('test-sns-channel');

Expand Down Expand Up @@ -333,7 +398,7 @@ describe('Test channel details', () => {
cy.contains('Actions').click({ force: true });
cy.contains('Delete').click({ force: true });
cy.get('input[placeholder="delete"]').type('delete');
cy.get('[data-test-subj="delete-channel-modal-delete-button"]').click({force: true})
cy.get('[data-test-subj="delete-channel-modal-delete-button"]').click({ force: true })
cy.contains('successfully deleted.').should('exist');
cy.contains('Test slack channel').should('exist');
})
Expand Down
Loading