[Backport 2.17] Fit and Finish UX Fixes Pt 2. #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* add default pill to encryption method Signed-off-by: Joanne Wang <jowg@amazon.com> * make table filters separate Signed-off-by: Joanne Wang <jowg@amazon.com> * run yarn test:jest-u Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com> (cherry picked from commit 13d80a5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan,
AWSHurneyt and
riysaxen-amzn
as code owners
AWSHurneyt
approved these changes
Sep 18, 2024
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
…inux.yml Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.17 #275 +/- ##
==========================================
+ Coverage 82.33% 82.34% +0.01%
==========================================
Files 55 55
Lines 1721 1722 +1
Branches 462 462
==========================================
+ Hits 1417 1418 +1
Misses 297 297
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amsiglan
approved these changes
Sep 20, 2024
jowg-amazon
added a commit
to jowg-amazon/dashboards-notifications
that referenced
this pull request
Sep 24, 2024
1 task
jowg-amazon
added a commit
to jowg-amazon/dashboards-notifications
that referenced
this pull request
Sep 24, 2024
AWSHurneyt
pushed a commit
that referenced
this pull request
Sep 24, 2024
* Revert "[Backport 2.17] Fit and Finish UX Fixes Pt 2. (#275)" This reverts commit 5ac0919. Signed-off-by: Joanne Wang <jowg@amazon.com> * Revert "Fit and Finish UX Fixes (#263) (#269)" This reverts commit b3dd31c. Signed-off-by: Joanne Wang <jowg@amazon.com> * Revert "Use TopNavControlButtonData for channel test button (#243) (#268)" This reverts commit 127eae4. Signed-off-by: Joanne Wang <jowg@amazon.com> * Revert "[Fit & Finish] Updated Fit and Finish guidelines (#256) (#259)" This reverts commit fb48dbc. Signed-off-by: Joanne Wang <jowg@amazon.com> --------- Signed-off-by: Joanne Wang <jowg@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 13d80a5 from #270.