Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI workflow for windows #271

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix CI workflow for windows #271

merged 1 commit into from
Sep 18, 2024

Conversation

jowg-amazon
Copy link
Contributor

Description

upload-artifact v4 doesn't allow uploading the same artifact name from multiple jobs. This PR updates the name of artifact that is uploaded so it's os specific.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jowg-amazon
fix ci
4e42f62 
Signed-off-by: Joanne Wang <jowg@amazon.com>
@jowg-amazon jowg-amazon marked this pull request as ready for review September 18, 2024 21:50
@AWSHurneyt AWSHurneyt merged commit 9fab860 into opensearch-project:main Sep 18, 2024
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 18, 2024
@github-actions
fix ci (#271)
4d1f644 
Signed-off-by: Joanne Wang <jowg@amazon.com>
(cherry picked from commit 9fab860)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 18, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 18, 2024
@github-actions
fix ci (#271)
ff95c93 
Signed-off-by: Joanne Wang <jowg@amazon.com>
(cherry picked from commit 9fab860)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 18, 2024
Merged
amsiglan pushed a commit that referenced this pull request Sep 18, 2024
@opensearch-trigger-bot @github-actions
fix ci (#271) (#272)
062ab9f 
(cherry picked from commit 9fab860)

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan pushed a commit that referenced this pull request Sep 18, 2024
@opensearch-trigger-bot @github-actions
fix ci (#271) (#273)
5f2e7a8 
(cherry picked from commit 9fab860)

Signed-off-by: Joanne Wang <jowg@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riysaxen-amzn riysaxen-amzn riysaxen-amzn approved these changes

@AWSHurneyt AWSHurneyt AWSHurneyt approved these changes

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@gaobinlong gaobinlong Awaiting requested review from gaobinlong gaobinlong is a code owner

@Hailong-am Hailong-am Awaiting requested review from Hailong-am Hailong-am is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@zhichao-aws zhichao-aws Awaiting requested review from zhichao-aws zhichao-aws is a code owner

@yuye-aws yuye-aws Awaiting requested review from yuye-aws yuye-aws is a code owner

@getsaurabh02 getsaurabh02 Awaiting requested review from getsaurabh02 getsaurabh02 is a code owner

@sbcd90 sbcd90 Awaiting requested review from sbcd90 sbcd90 is a code owner

@praveensameneni praveensameneni Awaiting requested review from praveensameneni praveensameneni is a code owner

@amsiglan amsiglan Awaiting requested review from amsiglan amsiglan is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jowg-amazon @riysaxen-amzn @AWSHurneyt