Skip to content

Commit

Permalink
Replaced wrongly formatted mock Slack URLs with properly formatted mo…
Browse files Browse the repository at this point in the history
…ck Slack URLs (#139)

* Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL

Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu>

* Update snapshot of unit tests

Ran `yar test:jest -u`

Signed-off-by: Aniruddh <ansriv2005@gmail.com>

---------

Signed-off-by: Aniruddh Srivastava <aniruddh@purdue.edu>
Signed-off-by: Aniruddh <ansriv2005@gmail.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
  • Loading branch information
Noir01 and Hailong-am authored Nov 28, 2023
1 parent 29c191c commit 7aba242
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .cypress/fixtures/test_slack_channel.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"config_type": "slack",
"is_enabled": true,
"slack": {
"url": "https://sample-slack-webhook"
"url": "https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2"
}
}
}
2 changes: 1 addition & 1 deletion .cypress/integration/channels.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ describe('Test create channels', () => {

cy.get('[placeholder="Enter channel name"]').type('Test slack channel');
cy.get('[data-test-subj="create-channel-slack-webhook-input"]').type(
'https://sample-slack-webhook'
'https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2'
);
cy.wait(delay);
cy.get('[data-test-subj="create-channel-send-test-message-button"]').click({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ exports[`<ChannelSettingsDetails /> spec renders Slack channel 1`] = `
<dd
class="euiDescriptionList__description"
>
https://chimehook
https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2
</dd>
</dl>
</div>
Expand Down
2 changes: 1 addition & 1 deletion test/mocks/mockData.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const mockSlack: ChannelItemType = {
config_type: 'slack',
is_enabled: false,
slack: {
url: 'https://chimehook',
url: 'https://hooks.slack.com/services/A123456/B1234567/A1B2C3D4E5F6G7H8I9J0K1L2',
},
config_id: 'test-slack',
created_time_ms: 1622670451891,
Expand Down

0 comments on commit 7aba242

Please sign in to comment.