Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add before layer id when adding documents label #387

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Apr 6, 2023

Description

  • Add beforeLayerId for documents label, so that the label layer will be added below the next map layer any time to avoid adding it in wrong layer order in some corner case.
  • Add test for public/model/layersFunction.ts
  • Clean extra MaplibreRef interface
  • Set selectedLayerConfig to be undefined after render

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@junqiu-lei junqiu-lei requested a review from a team April 6, 2023 19:54
@junqiu-lei junqiu-lei self-assigned this Apr 6, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #387 (1f20f12) into main (e6c0004) will decrease coverage by 7.21%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
- Coverage   73.33%   66.12%   -7.21%     
==========================================
  Files          26       31       +5     
  Lines         675      868     +193     
  Branches      103      144      +41     
==========================================
+ Hits          495      574      +79     
- Misses        152      266     +114     
  Partials       28       28              

see 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@junqiu-lei junqiu-lei merged commit e21cd6c into opensearch-project:main Apr 10, 2023
@junqiu-lei junqiu-lei deleted the label_order branch April 10, 2023 18:12
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 10, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit e21cd6c)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 10, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit e21cd6c)
junqiu-lei added a commit that referenced this pull request Apr 10, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit e21cd6c)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei added a commit that referenced this pull request Apr 10, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit e21cd6c)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants