Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change font opacity along with OpenSearch base map layer #375

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

junqiu-lei
Copy link
Member

@junqiu-lei junqiu-lei commented Apr 4, 2023

Description

In this PR:

  • Change font opacity along with OpenSearch base map layer
  • Refactor OpenSearch base map layer function

Before change:
image

After change:
image

Issues Resolved

#374
#300

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@junqiu-lei junqiu-lei self-assigned this Apr 4, 2023
@junqiu-lei junqiu-lei requested a review from a team April 4, 2023 01:07
@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

Merging #375 (d2db8cc) into main (853aad8) will increase coverage by 0.52%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   71.89%   72.41%   +0.52%     
==========================================
  Files          25       25              
  Lines         619      638      +19     
  Branches       96       98       +2     
==========================================
+ Hits          445      462      +17     
- Misses        149      150       +1     
- Partials       25       26       +1     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

VijayanB
VijayanB previously approved these changes Apr 4, 2023
naveentatikonda
naveentatikonda previously approved these changes Apr 4, 2023
@junqiu-lei junqiu-lei dismissed stale reviews from naveentatikonda and VijayanB via d2db8cc April 4, 2023 17:39
@junqiu-lei junqiu-lei merged commit 704bb13 into opensearch-project:main Apr 4, 2023
@junqiu-lei junqiu-lei deleted the font_opacity branch April 4, 2023 18:10
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 4, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit 704bb13)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 4, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit 704bb13)
junqiu-lei added a commit that referenced this pull request Apr 4, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit 704bb13)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei added a commit that referenced this pull request Apr 4, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit 704bb13)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants