Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BWC for label textType #340

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

junqiu-lei
Copy link
Member

Description

  • For backwards compatibility, set textType to BY_FIELD if textByField is set
  • Remove unused beforeLayerId for label layer

Issues Resolved

#321

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@junqiu-lei junqiu-lei requested a review from a team March 13, 2023 17:57
@junqiu-lei junqiu-lei self-assigned this Mar 13, 2023
@junqiu-lei junqiu-lei added backport 2.x enhancement New feature or request labels Mar 13, 2023
VijayanB
VijayanB previously approved these changes Mar 14, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #340 (ab67ba5) into main (397e666) will decrease coverage by 0.60%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #340      +/-   ##
==========================================
- Coverage   85.02%   84.42%   -0.60%     
==========================================
  Files          18       18              
  Lines         454      456       +2     
  Branches       71       71              
==========================================
- Hits          386      385       -1     
- Misses         46       49       +3     
  Partials       22       22              

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@junqiu-lei junqiu-lei merged commit 02d7d9a into opensearch-project:main Mar 14, 2023
@junqiu-lei junqiu-lei deleted the label_bwc_1 branch March 14, 2023 16:54
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 14, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit 02d7d9a)
junqiu-lei added a commit that referenced this pull request Mar 14, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit 02d7d9a)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
VijayanB pushed a commit to VijayanB/dashboards-maps that referenced this pull request Mar 20, 2023
…earch-project#344)

Signed-off-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit 02d7d9a)

Co-authored-by: Junqiu Lei <junqiu@amazon.com>
(cherry picked from commit d1bbfb4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants