feat: add localization for opensearch base map #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: raintygao <tygao@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 91.66% 89.83% -1.84%
==========================================
Files 10 12 +2
Lines 264 305 +41
Branches 34 42 +8
==========================================
+ Hits 242 274 +32
- Misses 16 21 +5
- Partials 6 10 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: raintygao <tygao@amazon.com>
junqiu-lei
reviewed
Mar 2, 2023
common/util.ts
Outdated
Comment on lines
12
to
13
| const OSD_LANGUAGES = ['en', 'es', 'fr', 'de', 'ja', 'ko', 'zh'], // all these codes are also supported in vector tiles map | ||
| FALLBACK_LANGUAGE = 'en'; |
There was a problem hiding this comment.
Could we move the constant to https://github.com/opensearch-project/dashboards-maps/blob/main/common/index.ts?
Signed-off-by: raintygao <tygao@amazon.com>
VijayanB
reviewed
Mar 4, 2023
public/model/OSMLayerFunctions.ts
Outdated
| @@ -41,6 +42,17 @@ const updateLayerConfig = (layerConfig: OSMLayerSpecification, maplibreRef: Mapl | |||
| handleStyleLayers(layerConfig, maplibreRef); | |||
| }; | |||
|
|
|||
| const localizationMapLayer = (maplibreRef: MaplibreRef, styleLayer: LayerSpecification) => { | |||
Signed-off-by: raintygao <tygao@amazon.com>
VijayanB
approved these changes
Mar 15, 2023
junqiu-lei
approved these changes
Mar 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
* feat: add localization for base map Signed-off-by: raintygao <tygao@amazon.com> * chore: update getlanguage order Signed-off-by: raintygao <tygao@amazon.com> * chore: move constants to index Signed-off-by: raintygao <tygao@amazon.com> * chore: update function name Signed-off-by: raintygao <tygao@amazon.com> --------- Signed-off-by: raintygao <tygao@amazon.com> (cherry picked from commit 8744efb)
junqiu-lei
pushed a commit
that referenced
this pull request
Mar 20, 2023
* feat: add localization for base map Signed-off-by: raintygao <tygao@amazon.com> * chore: update getlanguage order Signed-off-by: raintygao <tygao@amazon.com> * chore: move constants to index Signed-off-by: raintygao <tygao@amazon.com> * chore: update function name Signed-off-by: raintygao <tygao@amazon.com> --------- Signed-off-by: raintygao <tygao@amazon.com> (cherry picked from commit 8744efb) Co-authored-by: raintygao <tygao@amazon.com>
VijayanB
pushed a commit
to VijayanB/dashboards-maps
that referenced
this pull request
Mar 20, 2023
… (opensearch-project#351) * feat: add localization for base map Signed-off-by: raintygao <tygao@amazon.com> * chore: update getlanguage order Signed-off-by: raintygao <tygao@amazon.com> * chore: move constants to index Signed-off-by: raintygao <tygao@amazon.com> * chore: update function name Signed-off-by: raintygao <tygao@amazon.com> --------- Signed-off-by: raintygao <tygao@amazon.com> (cherry picked from commit 8744efb) Co-authored-by: raintygao <tygao@amazon.com>
|
cc @kavilla FYI. This is phase 1. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add localization for opensearch base map
Issues Resolved
#273
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.