Fix flaky test on cypress ci #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamshin
reviewed
Feb 8, 2023
| # Window is slow so wait longer | ||
| - name: Sleep until OSD server starts - windows | ||
| if: ${{ matrix.os == 'windows-latest' }} | ||
| - name: Sleep until OSD server starts |
There was a problem hiding this comment.
Why did we remove check for Windows?
There was a problem hiding this comment.
Just updated. Windows check still here, I was trying to merge different OS types wait in one check, but seems like they are using different shell.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 9 9
Lines 262 262
Branches 34 34
=======================================
Hits 240 240
Misses 16 16
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
cypress_ci
branch
from
3bec054
to
64ae83b
Compare
naveentatikonda
approved these changes
Feb 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2023
Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit ffb12e6)
junqiu-lei
added a commit
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei junqiu@amazon.com
Description
Add more wait time for OSD start run to fix flaky test on cypress ci
https://github.com/opensearch-project/dashboards-maps/actions/runs/4120910890/jobs/7116107984
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.