-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test on cypress ci #236
Conversation
# Window is slow so wait longer | ||
- name: Sleep until OSD server starts - windows | ||
if: ${{ matrix.os == 'windows-latest' }} | ||
- name: Sleep until OSD server starts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we remove check for Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updated. Windows check still here, I was trying to merge different OS types wait in one check, but seems like they are using different shell.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 91.60% 91.60%
=======================================
Files 9 9
Lines 262 262
Branches 34 34
=======================================
Hits 240 240
Misses 16 16
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
3bec054
to
64ae83b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Signed-off-by: Junqiu Lei <junqiu@amazon.com> (cherry picked from commit ffb12e6)
Signed-off-by: Junqiu Lei junqiu@amazon.com
Description
Add more wait time for OSD start run to fix flaky test on cypress ci
https://github.com/opensearch-project/dashboards-maps/actions/runs/4120910890/jobs/7116107984
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.