Update mapbounds logic #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanyl
reviewed
Jan 8, 2023
| // maps can render more than 1 copies of map at lower zoom level and displays | ||
| // one side from 1 copy and other side from other copy at higher zoom level if | ||
| // screen crosses internation dateline | ||
| function calculateBoundingBoxLngLimit(bounds: LngLatBounds) { |
| return lon; | ||
| // wrap bounds if only portion of globe is visible | ||
| return { | ||
| right: bounds.getSouthEast().wrap().lng, |
There was a problem hiding this comment.
I have a question here, suppose the current map lng bounding is [-170, 181], it is [-170, -179] after wrapping. It will return
{
right: -179,
left: -170,
}
The query would be
{
bottom_right: {
lon: -179,
lat: ...,
},
top_left: {
lon: -170,
lat: ...,
},
};
Is this what OpenSearch expecting?
There was a problem hiding this comment.
@ruanyl Sorry, do you mean will OpenSearch accept similar to following query or not
{
"DestLocation": {
"bottom_right": {
"lon": -176.8581559092076,
"lat": -38.91257159667413
},
"top_left": {
"lon": -173.24641047835382,
"lat": 78.53889135857452
}
}
}
There was a problem hiding this comment.
@VijayanB I mean will OpenSearch return the same results as expected in the bounding box [-170, 181] after the lng been wrapped in such case where bottom_right.lon < top_left .lon?
junqiu-lei
previously approved these changes
Jan 9, 2023
martin-gaievski
previously approved these changes
Jan 9, 2023
VijayanB
commented
Jan 9, 2023
| const boundsMinLng = bounds.getNorthWest().lng; | ||
| const boundsMaxLng = bounds.getSouthEast().lng; | ||
| // if bounds expands more than 360 then, consider complete globe is visible | ||
| if (boundsMaxLng - boundsMinLng >= MAX_LONGITUDE - MIN_LONGITUDE) { |
There was a problem hiding this comment.
Yeah. SouthEast will always be greater than NorthWest in Maplibre since we are not wrapping.
if more than one copies are visible, use max bounds else wrap bounds. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
dismissed stale reviews from martin-gaievski and junqiu-lei
via
1ce75fe
navneet1v
approved these changes
Jan 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 87.50% 87.64% +0.14%
==========================================
Files 6 6
Lines 176 178 +2
Branches 24 24
==========================================
+ Hits 154 156 +2
Misses 16 16
Partials 6 6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
junqiu-lei
approved these changes
Jan 10, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 10, 2023
if more than one copies are visible, use max bounds else wrap bounds. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 7eb646e)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.5 2.5
# Navigate to the new working tree
cd .worktrees/backport-2.5
# Create a new branch
git switch --create backport/backport-175-to-2.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7eb646e381337fcc9151d0c881b5b0dbe9ca4f14
# Push it to GitHub
git push --set-upstream origin backport/backport-175-to-2.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.5Then, create a pull request where the |
VijayanB
pushed a commit
that referenced
this pull request
Jan 10, 2023
if more than one copies are visible, use max bounds else wrap bounds. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com>
VijayanB
added a commit
to VijayanB/dashboards-maps
that referenced
this pull request
Jan 10, 2023
if more than one copies are visible, use max bounds else wrap bounds. Signed-off-by: Vijayan Balasubramanian <balasvij@amazon.com> (cherry picked from commit 7eb646e)
VijayanB
added a commit
that referenced
this pull request
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
if more than one copies are visible, use max bounds else wrap bounds to cover international date line.
Signed-off-by: Vijayan Balasubramanian balasvij@amazon.com
Issues Resolved
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.