add chat routes unit tests #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 83.72% 91.61% +7.89%
==========================================
Files 43 43
Lines 1026 1026
Branches 239 239
==========================================
+ Hits 859 940 +81
+ Misses 166 85 -81
Partials 1 1 ☔ View full report in Codecov by Sentry. |
wanglam
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
raintygao
as code owners
SuZhou-Joe
reviewed
Dec 20, 2023
server/routes/chat_routes.test.ts
Outdated
Comment on lines
58
to
69
| const triggerGetSession = (sessionId: string) => | ||
| triggerHandler(router, { | ||
| method: 'get', | ||
| path: `${ASSISTANT_API.SESSION}/{sessionId}`, | ||
| req: httpServerMock.createRawRequest({ params: { sessionId } }), | ||
| }); | ||
| const triggerGetSessions = (query: GetSessionsSchema) => | ||
| triggerHandler(router, { | ||
| method: 'get', | ||
| path: ASSISTANT_API.SESSIONS, | ||
| req: httpServerMock.createRawRequest({ query }), | ||
| }); |
There was a problem hiding this comment.
Actually there are get_session.test.ts and get_sessions.test.ts files which have already done similar test. Maybe remove the standalone files to keep just one test case?
SuZhou-Joe
approved these changes
Dec 20, 2023
Signed-off-by: Lin Wang <wonglam@amazon.com>
raintygao
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for chat routes, except sendMessage and regenerate.
The unit tests for regenerate has been provided in another PR (#78 ).
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.