Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for session load and sessions service #68

Merged

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Dec 13, 2023

Description

  1. Fix status turn to idle after load failed
  2. Add unit tests for session load and sessions service

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7695943) 74.29% compared to head (93887c9) 75.39%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   74.29%   75.39%   +1.09%     
==========================================
  Files          43       43              
  Lines        1023     1024       +1     
  Branches      245      245              
==========================================
+ Hits          760      772      +12     
+ Misses        261      250      -11     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wanglam wanglam marked this pull request as ready for review December 13, 2023 08:39
@wanglam wanglam changed the base branch from feature/agent-framework to main December 14, 2023 03:01
@wanglam wanglam changed the title test: add unit tests for session load and sessions service [DON'T MERGE]test: add unit tests for session load and sessions service Dec 14, 2023
@wanglam wanglam changed the title [DON'T MERGE]test: add unit tests for session load and sessions service test: add unit tests for session load and sessions service Dec 14, 2023
Signed-off-by: Lin Wang <wonglam@amazon.com>
@wanglam wanglam merged commit 09d0766 into opensearch-project:main Dec 15, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants