test: add unit test for chat history page #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanglam
force-pushed
the
feat-add-chat-history-page-ut
branch
from
12e19c4
to
b9f07db
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/agent-framework #55 +/- ##
============================================================
+ Coverage 48.75% 58.99% +10.23%
============================================================
Files 46 46
Lines 1087 1090 +3
Branches 250 251 +1
============================================================
+ Hits 530 643 +113
+ Misses 548 440 -108
+ Partials 9 7 -2 ☔ View full report in Codecov by Sentry. |
ruanyl
changed the title
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
force-pushed
the
feat-add-chat-history-page-ut
branch
from
b9f07db
to
52e5ab5
Compare
ruanyl
approved these changes
Dec 12, 2023
| ); | ||
|
|
||
| expect(onChatHistoryTitleClickMock).not.toHaveBeenCalled(); | ||
| act(() => { |
There was a problem hiding this comment.
Are these act necessary in these cases? I thought we only need act when the operation causes state change which end up with updating the component tree.
There was a problem hiding this comment.
Agree with you. The act is unnecessary here. Will remove them.
Signed-off-by: Lin Wang <wonglam@amazon.com>
raintygao
approved these changes
Dec 12, 2023
wanglam
merged commit 634053e
into
opensearch-project:feature/agent-framework
10 checks passed
joshuali925
pushed a commit
to joshuali925/dashboards-assistant
that referenced
this pull request
Dec 13, 2023
* test: add unit test for chst history page Signed-off-by: Lin Wang <wonglam@amazon.com> * test: add unit tests for chat history list Signed-off-by: Lin Wang <wonglam@amazon.com> * test: add unit tests for chat history search list Signed-off-by: Lin Wang <wonglam@amazon.com> * test: remove unnecessary act Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.