Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add unit tests for edit and delete modal #50

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Dec 7, 2023

Description

  1. Add unit tests for EditConversationNameModal
  2. Add unit tests for DeleteConversationConfirmModal

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@wanglam wanglam marked this pull request as ready for review December 7, 2023 05:21
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9663fb1) 27.40% compared to head (ae7da45) 33.03%.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/agent-framework      #50      +/-   ##
===========================================================
+ Coverage                    27.40%   33.03%   +5.63%     
===========================================================
  Files                           40       40              
  Lines                          905      905              
  Branches                       223      223              
===========================================================
+ Hits                           248      299      +51     
+ Misses                         650      599      -51     
  Partials                         7        7              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
@wanglam wanglam force-pushed the add-ut-for-edit-and-delete-conversation branch from c7ca9b2 to ae7da45 Compare December 8, 2023 09:09
@wanglam wanglam changed the title feat: add unit tests for edit and delete modal test: add unit tests for edit and delete modal Dec 8, 2023
@wanglam wanglam merged commit c70bcfc into opensearch-project:feature/agent-framework Dec 11, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants