-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Set logo config in assistant and read logo by config #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raintygao
requested review from
lezzago,
joshuali925,
anirudha,
ruanyl,
SuZhou-Joe,
xluo-aws,
gaobinlong,
Hailong-am and
wanglam
as code owners
January 22, 2025 02:21
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
wanglam
reviewed
Jan 22, 2025
Signed-off-by: tygao <tygao@amazon.com>
wanglam
reviewed
Jan 22, 2025
Signed-off-by: tygao <tygao@amazon.com>
wanglam
approved these changes
Jan 22, 2025
ruanyl
approved these changes
Jan 22, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
* feat: set logo config in assistant Signed-off-by: tygao <tygao@amazon.com> * doc: add changelog Signed-off-by: tygao <tygao@amazon.com> * utilize getLogoIcon Signed-off-by: tygao <tygao@amazon.com> * keep sparkle Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com> (cherry picked from commit 07ce25e) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
raintygao
pushed a commit
that referenced
this pull request
Jan 22, 2025
hutiechuan
pushed a commit
to hutiechuan/dashboards-assistant
that referenced
this pull request
Jan 24, 2025
…h-project#401) * feat: set logo config in assistant Signed-off-by: tygao <tygao@amazon.com> * doc: add changelog Signed-off-by: tygao <tygao@amazon.com> * utilize getLogoIcon Signed-off-by: tygao <tygao@amazon.com> * keep sparkle Signed-off-by: tygao <tygao@amazon.com> --------- Signed-off-by: tygao <tygao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set logo config in assistant and read logo by config
Screenshot
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.