Feat add toasts for conversation actions #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanglam
changed the title
|
Overall I do not see error toast when deleting / updating, is that expected? |
Hailong-am
reviewed
Dec 4, 2023
SuZhou-Joe
reviewed
Dec 4, 2023
Will ask if there are any common error toasts, will be added in the future PRs. |
wanglam
force-pushed
the
feat-add-toats-for-conversation-actions
branch
from
4653aa8
to
9c36f72
Compare
wanglam
changed the base branch from
feature/langchain
to
feature/agent-framework
raintygao
approved these changes
Dec 5, 2023
SuZhou-Joe
approved these changes
Dec 6, 2023
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
wanglam
force-pushed
the
feat-add-toats-for-conversation-actions
branch
from
9c36f72
to
6c5f87d
Compare
Signed-off-by: Lin Wang <wonglam@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/agent-framework #39 +/- ##
===========================================================
+ Coverage 22.86% 23.31% +0.44%
===========================================================
Files 42 42
Lines 892 918 +26
Branches 221 225 +4
===========================================================
+ Hits 204 214 +10
- Misses 681 697 +16
Partials 7 7 ☔ View full report in Codecov by Sentry. |
wanglam
merged commit 40838c6
into
opensearch-project:feature/agent-framework
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.Add toasts for edit modal
2.Add toasts for delete modal
3.Add toasts for new conversation
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.